Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Variable move power is called after the power boost from abilities, overriding the boosts #5313

Open
Mourouh opened this issue Feb 13, 2025 · 0 comments
Labels
Ability Affects an ability Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction

Comments

@Mourouh
Copy link

Mourouh commented Feb 13, 2025

Describe the bug

Link to Discord bug issue
https://discord.com/channels/1125469663833370665/1339634046543593564

Moves with variable power (VariablePowerAttr) are called after the function for abilities that boost the move's power (VariableMovePowerAbAttr). This leads to the boost of those abilities being overriden, effectively making them not work.

Moves affected include moves based on weight (Heavy Slam), HP (Flail, Wring Out), Friendship (Return, Frustration) or variable Power moves (Magnitude).

These affect all abilities that affect the power of the moves, like Aerilate or Tough Claws.

Reproduction

const overrides = {ABILITY_OVERRIDE: Abilities.AERILATE, MOVESET_OVERRIDE: [Moves.CRUSH_GRIP, Moves.DOUBLE_EDGE], OPP_MOVESET_OVERRIDE: [Moves.SPLASH, Moves.SPLASH, Moves.SPLASH, Moves.SPLASH], OPP_LEVEL_OVERRIDE: 10} satisfies Partial<InstanceType<typeof DefaultOverrides>>;

This will let you see Crush Grip's power in console not getting boosted. Note: Crush Grip is only 120 BP when opponent is at full HP

Expected behavior

Variable Power Moves get boosted by abilities as intended. Proof of expected behaviour in Videos

Screenshots / Videos

Showdown example of variable power moves getting the boost from Refrigerate.
https://github.com/user-attachments/assets/46f74f01-8df1-4d0b-909b-f56756b89fd4

Screenshot of console. Crush Grip (120 BP) is not getting Aerilate boost, while Double-Edge (also 120 BP, x1.2=144 BP) is
Image

Session export file

N/A

User data export file

N/A

Additional context

No response

@Mourouh Mourouh added the Triage The issue needs triage label Feb 13, 2025
@Snailman11 Snailman11 added P2 Bug Minor. Non crashing Incorrect move/ability/interaction and removed Triage The issue needs triage labels Feb 13, 2025
@Snailman11 Snailman11 moved this from To triage to Ready in PokéRogue Bug Management Feb 13, 2025
@Snailman11 Snailman11 added Move Affects a move Ability Affects an ability labels Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ability Affects an ability Move Affects a move P2 Bug Minor. Non crashing Incorrect move/ability/interaction
Projects
Status: Ready
Development

No branches or pull requests

2 participants