Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use units with atol in tests #175

Open
rebeccafair opened this issue Jun 22, 2021 · 0 comments
Open

Use units with atol in tests #175

rebeccafair opened this issue Jun 22, 2021 · 0 comments
Labels
nice to have Not urgently required, but would be an improvement

Comments

@rebeccafair
Copy link
Member

Changing units (as seen in #174) also requires changing of tolerances in tests. However, this could be easily forgotten and end up with a tolerance that is much larger in magnitude than the values themselves, making the tests useless. We should make use of units in our tolerances to avoid this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nice to have Not urgently required, but would be an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rebeccafair