Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handling/plotting of multiple Spectrum2D #158

Open
rebeccafair opened this issue May 18, 2021 · 1 comment
Open

Better handling/plotting of multiple Spectrum2D #158

rebeccafair opened this issue May 18, 2021 · 1 comment
Labels
nice to have Not urgently required, but would be an improvement

Comments

@rebeccafair
Copy link
Member

rebeccafair commented May 18, 2021

This has arisen as a result of discussion in #155 (for #116). Multiple Spectrum2D objects (e.g. for multiple PDOS maps) are currently just returned as lists, and plotted manually with plot_2d_to_axis. It may be useful to provide a function to automatically plot multiple Spectrum2D, depending on the ongoing use of PDOS maps and if there are any other use cases.

@rebeccafair rebeccafair changed the title Better handling Better handling/plotting of multiple Spectrum2D May 18, 2021
@rebeccafair rebeccafair added the nice to have Not urgently required, but would be an improvement label May 18, 2021
@ajjackson
Copy link
Collaborator

As commented on #155 I am becoming convinced that a Spectrum2DCollection would be useful if it had metadata search/split/combine capabilities. In which case we could update plot_2d to work very analogously to plot_1d, with a list of Spectrum2DCollections being tiled left-to-right by list elements and top-to-bottom by the contained spectra.

(And, presumably, blowing up if the metadata don't match...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nice to have Not urgently required, but would be an improvement
Projects
None yet
Development

No branches or pull requests

2 participants