From 83df5f761ee08db4e2de556b19f9d894087f0622 Mon Sep 17 00:00:00 2001
From: pnzrr <pnzrrr@pm.me>
Date: Thu, 29 Feb 2024 20:55:53 -0700
Subject: [PATCH 1/4] update button labels

---
 src/pages/profile/signin.tsx | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/pages/profile/signin.tsx b/src/pages/profile/signin.tsx
index 37b0ef3..3686143 100644
--- a/src/pages/profile/signin.tsx
+++ b/src/pages/profile/signin.tsx
@@ -19,12 +19,16 @@ import { AIACommand } from "services/aia-command";
 import P2Toast from "components/utils/toast";
 import { Key, Lock, Smartphone } from "lucide-react";
 
+const PASSWORD = "password";
+const TWO_FACTOR_AUTH = "2fa";
 const WEB_AUTH_N = "webauthn";
 const WEB_AUTH_N_REGISTER = "webauthn-register";
 const WEB_AUTH_N_PASSWORDLESS = "webauthn-passwordless";
 const WEB_AUTH_N_PASSWORDLESS_REGISTER = "webauthn-register-passwordless";
 const OTP = "otp";
 
+type CredentialType = PASSWORD | TWO_FACTOR_AUTH | WEB_AUTH_N | OTP;
+
 const time = (time: string | undefined): string => {
   if (time === undefined) return "unknown";
   let t: number = Number(time);
@@ -84,7 +88,7 @@ const SigninProfile = () => {
   ];
 
   const rowsForType = (
-    credentialType: string,
+    credentialType: CredentialType,
     credentials: CredentialRepresentation[]
   ): TableRows => {
     const metadatas: UserCredentialMetadataRepresentation[] = [];
@@ -147,7 +151,7 @@ const SigninProfile = () => {
             />
             <Table
               columns={cols}
-              rows={rowsForType("password", credentials)}
+              rows={rowsForType(PASSWORD, credentials)}
               isLoading={isLoading}
             />
           </div>
@@ -168,7 +172,7 @@ const SigninProfile = () => {
               {isLoading && (
                 <Table
                   columns={cols}
-                  rows={rowsForType("password", credentials)}
+                  rows={rowsForType(TWO_FACTOR_AUTH, credentials)}
                   isLoading={isLoading}
                 />
               )}
@@ -219,7 +223,7 @@ const SigninProfile = () => {
                       description={t("useYourSecurityKeyToSignIn")}
                       variant="small"
                     />
-                    {rowsForType("webauthn", credentials).length !== 0 && (
+                    {rowsForType(WEB_AUTH_N, credentials).length !== 0 && (
                       <Button
                         isBlackButton
                         onClick={() => setUpCredential(WEB_AUTH_N_REGISTER)}
@@ -230,7 +234,7 @@ const SigninProfile = () => {
                   </div>
                   <Table
                     columns={cols}
-                    rows={rowsForType("webauthn", credentials)}
+                    rows={rowsForType(WEB_AUTH_N, credentials)}
                     isLoading={isLoading}
                     emptyState={
                       <div>

From d040729a611aed3a1208527487af6106eb589f02 Mon Sep 17 00:00:00 2001
From: pnzrr <pnzrrr@pm.me>
Date: Mon, 4 Mar 2024 08:22:16 -0700
Subject: [PATCH 2/4] adjust typing

---
 src/pages/profile/signin.tsx | 76 +++++++++++++++++++++++-------------
 1 file changed, 49 insertions(+), 27 deletions(-)

diff --git a/src/pages/profile/signin.tsx b/src/pages/profile/signin.tsx
index 3686143..0cc691a 100644
--- a/src/pages/profile/signin.tsx
+++ b/src/pages/profile/signin.tsx
@@ -19,15 +19,15 @@ import { AIACommand } from "services/aia-command";
 import P2Toast from "components/utils/toast";
 import { Key, Lock, Smartphone } from "lucide-react";
 
-const PASSWORD = "password";
-const TWO_FACTOR_AUTH = "2fa";
-const WEB_AUTH_N = "webauthn";
-const WEB_AUTH_N_REGISTER = "webauthn-register";
-const WEB_AUTH_N_PASSWORDLESS = "webauthn-passwordless";
-const WEB_AUTH_N_PASSWORDLESS_REGISTER = "webauthn-register-passwordless";
-const OTP = "otp";
-
-type CredentialType = PASSWORD | TWO_FACTOR_AUTH | WEB_AUTH_N | OTP;
+enum CredentialType {
+  PASSWORD = "password",
+  TWO_FACTOR_AUTH = "2fa",
+  WEB_AUTH_N = "webauthn",
+  WEB_AUTH_N_REGISTER = "webauthn-register",
+  WEB_AUTH_N_PASSWORDLESS = "webauthn-passwordless",
+  WEB_AUTH_N_PASSWORDLESS_REGISTER = "webauthn-register-passwordless",
+  OTP = "otp",
+}
 
 const time = (time: string | undefined): string => {
   if (time === undefined) return "unknown";
@@ -42,11 +42,13 @@ const SigninProfile = () => {
   });
   const [deleteCredential] = useDeleteCredentialMutation();
 
-  const hasWebAuthN = credentials.find((cred) => cred.type === WEB_AUTH_N);
+  const hasWebAuthN = credentials.find(
+    (cred) => cred.type === CredentialType.WEB_AUTH_N
+  );
   const hasWebAuthNPasswordLess = credentials.find(
-    (cred) => cred.type === WEB_AUTH_N_PASSWORDLESS
+    (cred) => cred.type === CredentialType.WEB_AUTH_N_PASSWORDLESS
   );
-  const hasOTP = credentials.find((cred) => cred.type === OTP);
+  const hasOTP = credentials.find((cred) => cred.type === CredentialType.OTP);
 
   const removeCredential = (
     credential: CredentialMetadataRepresentation
@@ -109,14 +111,16 @@ const SigninProfile = () => {
               isCompact
               className="inline-flex w-full justify-center sm:ml-3 sm:w-auto"
               onClick={() => {
-                if (credentialType === "password") {
+                if (credentialType === CredentialType.PASSWORD) {
                   updateAIA("UPDATE_PASSWORD");
                 } else {
                   removeCredential(metadata.credential!);
                 }
               }}
             >
-              {credentialType === "password" ? t("update") : t("remove")}
+              {credentialType === CredentialType.PASSWORD
+                ? t("update")
+                : t("remove")}
             </Button>
           )}
         </>
@@ -151,7 +155,7 @@ const SigninProfile = () => {
             />
             <Table
               columns={cols}
-              rows={rowsForType(PASSWORD, credentials)}
+              rows={rowsForType(CredentialType.PASSWORD, credentials)}
               isLoading={isLoading}
             />
           </div>
@@ -172,7 +176,10 @@ const SigninProfile = () => {
               {isLoading && (
                 <Table
                   columns={cols}
-                  rows={rowsForType(TWO_FACTOR_AUTH, credentials)}
+                  rows={rowsForType(
+                    CredentialType.TWO_FACTOR_AUTH,
+                    credentials
+                  )}
                   isLoading={isLoading}
                 />
               )}
@@ -188,7 +195,8 @@ const SigninProfile = () => {
                       variant="small"
                     />
 
-                    {rowsForType(OTP, credentials).length !== 0 && (
+                    {rowsForType(CredentialType.OTP, credentials).length !==
+                      0 && (
                       <Button
                         isBlackButton
                         onClick={() => setUpCredential("CONFIGURE_TOTP")}
@@ -199,7 +207,7 @@ const SigninProfile = () => {
                   </div>
                   <Table
                     columns={cols}
-                    rows={rowsForType(OTP, credentials)}
+                    rows={rowsForType(CredentialType.OTP, credentials)}
                     isLoading={isLoading}
                     emptyState={
                       <div>
@@ -223,10 +231,13 @@ const SigninProfile = () => {
                       description={t("useYourSecurityKeyToSignIn")}
                       variant="small"
                     />
-                    {rowsForType(WEB_AUTH_N, credentials).length !== 0 && (
+                    {rowsForType(CredentialType.WEB_AUTH_N, credentials)
+                      .length !== 0 && (
                       <Button
                         isBlackButton
-                        onClick={() => setUpCredential(WEB_AUTH_N_REGISTER)}
+                        onClick={() =>
+                          setUpCredential(CredentialType.WEB_AUTH_N_REGISTER)
+                        }
                       >
                         {t("setUpSecurityKey")}
                       </Button>
@@ -234,13 +245,15 @@ const SigninProfile = () => {
                   </div>
                   <Table
                     columns={cols}
-                    rows={rowsForType(WEB_AUTH_N, credentials)}
+                    rows={rowsForType(CredentialType.WEB_AUTH_N, credentials)}
                     isLoading={isLoading}
                     emptyState={
                       <div>
                         <Button
                           isBlackButton
-                          onClick={() => setUpCredential(WEB_AUTH_N_REGISTER)}
+                          onClick={() =>
+                            setUpCredential(CredentialType.WEB_AUTH_N_REGISTER)
+                          }
                         >
                           {t("setUpSecurityKey")}
                         </Button>
@@ -270,12 +283,16 @@ const SigninProfile = () => {
                   description={t("useYourSecurityKeyForPasswordlessSignIn")}
                   variant="small"
                 />
-                {rowsForType(WEB_AUTH_N_PASSWORDLESS, credentials).length !==
-                  0 && (
+                {rowsForType(
+                  CredentialType.WEB_AUTH_N_PASSWORDLESS,
+                  credentials
+                ).length !== 0 && (
                   <Button
                     isBlackButton
                     onClick={() =>
-                      setUpCredential(WEB_AUTH_N_PASSWORDLESS_REGISTER)
+                      setUpCredential(
+                        CredentialType.WEB_AUTH_N_PASSWORDLESS_REGISTER
+                      )
                     }
                   >
                     {t("setUpSecurityKey")}
@@ -284,14 +301,19 @@ const SigninProfile = () => {
               </div>
               <Table
                 columns={cols}
-                rows={rowsForType(WEB_AUTH_N_PASSWORDLESS, credentials)}
+                rows={rowsForType(
+                  CredentialType.WEB_AUTH_N_PASSWORDLESS,
+                  credentials
+                )}
                 isLoading={isLoading}
                 emptyState={
                   <div>
                     <Button
                       isBlackButton
                       onClick={() =>
-                        setUpCredential(WEB_AUTH_N_PASSWORDLESS_REGISTER)
+                        setUpCredential(
+                          CredentialType.WEB_AUTH_N_PASSWORDLESS_REGISTER
+                        )
                       }
                     >
                       {t("setUpSecurityKey")}

From 9d78cd60ea2bf0d810b726526115bf11801b8be0 Mon Sep 17 00:00:00 2001
From: pnzrr <pnzrrr@pm.me>
Date: Mon, 4 Mar 2024 08:28:46 -0700
Subject: [PATCH 3/4] add another action to run a test as part of a PR

---
 .github/workflows/test.yml | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)
 create mode 100644 .github/workflows/test.yml

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
new file mode 100644
index 0000000..3ab62d7
--- /dev/null
+++ b/.github/workflows/test.yml
@@ -0,0 +1,20 @@
+name: test
+
+on:
+  pull_request:
+    branches: [main]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+    if: "!contains(github.event.head_commit.message, '[ci skip]')"
+
+    steps:
+      - uses: actions/checkout@v3
+
+      - name: Build and Test
+        uses: qcastel/github-actions-maven-cmd@master
+        env:
+          CI: ""
+        with:
+          maven-args: "clean install -Dmaven.test.skip=true -Ddockerfile.skip -DdockerCompose.skip -Djib.skip"

From e60e8930db4b9828fede874c875236f08c38ff9d Mon Sep 17 00:00:00 2001
From: pnzrr <pnzrrr@pm.me>
Date: Mon, 4 Mar 2024 08:30:57 -0700
Subject: [PATCH 4/4] remove ci skip line

---
 .github/workflows/test.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
index 3ab62d7..40d00bd 100644
--- a/.github/workflows/test.yml
+++ b/.github/workflows/test.yml
@@ -7,7 +7,6 @@ on:
 jobs:
   build:
     runs-on: ubuntu-latest
-    if: "!contains(github.event.head_commit.message, '[ci skip]')"
 
     steps:
       - uses: actions/checkout@v3