Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outstanding tests #3

Open
xgp opened this issue Mar 29, 2024 · 1 comment
Open

outstanding tests #3

xgp opened this issue Mar 29, 2024 · 1 comment

Comments

@xgp
Copy link
Member

xgp commented Mar 29, 2024

fails

UserSessionInitializerTest#testUserSessionInitializer @rtufisi

  • I don't think this is implemented yet
  • Expected: is <3L> but: was <0L>

UserSessionInitializerTest#testUserSessionInitializerWithDeletingClient @rtufisi

  • I don't think this is implemented yet
  • Expected: is <1L> but: was <0L>

won't do (for now)

These are both because they are expecting *Model classes to be used between transactions, which is never actually done inside Keycloak. Disabling these tests for now.

UserSessionProviderModelTest#testImportUserSessions

  • Caused by: java.lang.IllegalStateException: Session/EntityManager is closed

UserSessionProviderModelTest#testExpiredClientSessions

  • Caused by: java.lang.IllegalStateException: Session/EntityManager is closed

works

UserSessionProviderModelTest#testGetByClient f38f339 @rtufisi
UserSessionProviderModelTest#testRemoveSessions 1386e13 @rtufisi
UserSessionExpirationTest#testClientSessionIdleTimeoutOverride 98cc8db @xgp
UserSessionExpirationTest#testClientSessionIdleTimeoutOverrideTtl 98cc8db @xgp
UserSessionProviderModelTest#testActiveClientSessionStats f0a4779 @rtufisi
UserSessionProviderModelTest#testBrokerUserSessions affa1c5 @rtufisi
UserSessionProviderModelTest#testTransientUserSessionIsNotPersisted 0022527 @xgp
UserSessionProviderModelTest#testTransientUserSession 0022527 @xgp
UserSessionProviderModelTest#testClientSessionIsNotPersistedForTransientUserSession 0022527 @xgp
UserSessionProviderModelTest#testMultipleSessionsRemovalInOneTransaction
UserSessionProviderModelTest#testRemoveUserSession
UserSessionProviderModelTest#testRemoveUserSessionsByRealm
UserSessionConcurrencyTest#testConcurrentNotesChange
UserSessionProviderModelTest#testCreateSessions
UserSessionProviderModelTest#testUpdateSession
UserSessionProviderModelTest#testUpdateSessionInSameTransaction
UserSessionProviderModelTest#testRestartSession
UserSessionProviderModelTest#testCreateClientSession
UserSessionProviderModelTest#testUpdateClientSession
UserSessionProviderModelTest#testUpdateClientSessionWithGetByClientId
UserSessionProviderModelTest#testUpdateClientSessionInSameTransaction
UserSessionProviderModelTest#testGetUserSessions
UserSessionProviderModelTest#testRemoveUserSessionsByUser
UserSessionProviderModelTest#testOnClientRemoved
UserSessionProviderModelTest#testGetByClientPaginated
UserSessionProviderModelTest#testCreateAndGetInSameTransaction
UserSessionProviderModelTest#testAuthenticatedClientSessions
UserSessionProviderModelTest#testUserSessionNotes
UserSessionProviderModelTest#testClientSessionToUserSessionReference
UserSessionExpirationTest#testClientSessionIdleTimeout
UserSessionExpirationTest#testDeleteSession

@rtufisi
Copy link
Contributor

rtufisi commented Apr 15, 2024

Last test standing UserSessionInitializerTest. Please have a look @xgp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants