refactor: flatten v0 specs

Author: gjcolombo

bin/propolis-server/src/lib/initializer.rs

@@ -1009,9 +1009,9 @@ impl<'a> MachineInitializer<'a> {
         info!(
             self.log,
             "Generating bootorder with order: {:?}",
-            self.spec.boot_order.as_ref()
+            self.spec.boot_settings.as_ref()
         );
-        let Some(boot_names) = self.spec.boot_order.as_ref() else {
+        let Some(boot_names) = self.spec.boot_settings.as_ref() else {
             return Ok(None);
         };
 
@@ -1033,7 +1033,7 @@ impl<'a> MachineInitializer<'a> {
                 bdf
             };
 
-        for boot_entry in boot_names.iter() {
+        for boot_entry in boot_names.order.iter() {
             // Theoretically we could support booting from network devices by
             // matching them here and adding their PCI paths, but exactly what
             // would happen is ill-understood. So, only check disks here.

bin/propolis-server/src/lib/server.rs

@@ -131,7 +131,7 @@ fn instance_spec_from_request(
 
     if let Some(boot_settings) = request.boot_settings.as_ref() {
         for item in boot_settings.order.iter() {
-            spec_builder.add_boot_option(item)?;
+            spec_builder.add_boot_option(item.clone())?;
         }
     }