Skip to content

Commit 0bdabd8

Browse files
committed
touch up some doc comments
1 parent deb14a9 commit 0bdabd8

File tree

3 files changed

+23
-1
lines changed

3 files changed

+23
-1
lines changed

bin/propolis-server/src/lib/migrate/compat.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,8 @@
22
// License, v. 2.0. If a copy of the MPL was not distributed with this
33
// file, You can obtain one at https://mozilla.org/MPL/2.0/.
44

5-
//! Checks for compatibility of two instance specs.
5+
//! Associated functions for the [`crate::spec::Spec`] type that determine
6+
//! whether two specs describe migration-compatible VMs.
67
78
use std::collections::HashMap;
89

crates/propolis-api-types/src/instance_spec/components/devices.rs

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,13 +108,21 @@ pub struct QemuPvpanic {
108108
// Structs for Falcon devices. These devices don't support live migration.
109109
//
110110

111+
/// Describes a SoftNPU PCI device.
112+
///
113+
/// This is only supported by Propolis servers compiled with the `falcon`
114+
/// feature.
111115
#[derive(Clone, Deserialize, Serialize, Debug, JsonSchema)]
112116
#[serde(deny_unknown_fields)]
113117
pub struct SoftNpuPciPort {
114118
/// The PCI path at which to attach the guest to this port.
115119
pub pci_path: PciPath,
116120
}
117121

122+
/// Describes a SoftNPU network port.
123+
///
124+
/// This is only supported by Propolis servers compiled with the `falcon`
125+
/// feature.
118126
#[derive(Clone, Deserialize, Serialize, Debug, JsonSchema)]
119127
#[serde(deny_unknown_fields)]
120128
pub struct SoftNpuPort {
@@ -125,13 +133,22 @@ pub struct SoftNpuPort {
125133
pub backend_name: String,
126134
}
127135

136+
/// Describes a PCI device that shares host files with the guest using the P9
137+
/// protocol.
138+
///
139+
/// This is only supported by Propolis servers compiled with the `falcon`
140+
/// feature.
128141
#[derive(Clone, Deserialize, Serialize, Debug, JsonSchema)]
129142
#[serde(deny_unknown_fields)]
130143
pub struct SoftNpuP9 {
131144
/// The PCI path at which to attach the guest to this port.
132145
pub pci_path: PciPath,
133146
}
134147

148+
/// Describes a filesystem to expose through a P9 device.
149+
///
150+
/// This is only supported by Propolis servers compiled with the `falcon`
151+
/// feature.
135152
#[derive(Clone, Deserialize, Serialize, Debug, JsonSchema)]
136153
#[serde(deny_unknown_fields)]
137154
pub struct P9fs {

openapi/propolis-server.json

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1598,6 +1598,7 @@
15981598
"additionalProperties": false
15991599
},
16001600
"P9fs": {
1601+
"description": "Describes a filesystem to expose through a P9 device.\n\nThis is only supported by Propolis servers compiled with the `falcon` feature.",
16011602
"type": "object",
16021603
"properties": {
16031604
"chunk_size": {
@@ -1740,6 +1741,7 @@
17401741
"minimum": 0
17411742
},
17421743
"SoftNpuP9": {
1744+
"description": "Describes a PCI device that shares host files with the guest using the P9 protocol.\n\nThis is only supported by Propolis servers compiled with the `falcon` feature.",
17431745
"type": "object",
17441746
"properties": {
17451747
"pci_path": {
@@ -1757,6 +1759,7 @@
17571759
"additionalProperties": false
17581760
},
17591761
"SoftNpuPciPort": {
1762+
"description": "Describes a SoftNPU PCI device.\n\nThis is only supported by Propolis servers compiled with the `falcon` feature.",
17601763
"type": "object",
17611764
"properties": {
17621765
"pci_path": {
@@ -1774,6 +1777,7 @@
17741777
"additionalProperties": false
17751778
},
17761779
"SoftNpuPort": {
1780+
"description": "Describes a SoftNPU network port.\n\nThis is only supported by Propolis servers compiled with the `falcon` feature.",
17771781
"type": "object",
17781782
"properties": {
17791783
"backend_name": {

0 commit comments

Comments
 (0)