Skip to content

Commit 96ec5f8

Browse files
authored
move back to Rust 1.81 (#7020)
Rust 1.82 has a rather serious compile time regression in Diesel-generated code: rust-lang/rust#132064. This makes Omicron builds up to twice as slow. We used to be on 1.80 before moving to 1.82, but 1.81 has some nice things like `#[expect]`. So move to 1.81. We expect the regression to be fixed in Rust 1.84. Thanks to @jmpesp for tracking this down!
1 parent 463a368 commit 96ec5f8

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

rust-toolchain.toml

+7-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
[toolchain]
22
# We choose a specific toolchain (rather than "stable") for repeatability. The
33
# intent is to keep this up-to-date with recently-released stable Rust.
4-
channel = "1.82.0"
4+
#
5+
# NOTE: Rust 1.82 has a large compile time regression in Diesel-generated
6+
# code: https://github.com/rust-lang/rust/issues/132064. Before moving to a
7+
# newer Rust, ensure that the regression is addressed and that nexus-db-queries
8+
# and omicron-nexus don't take much longer to compile!
9+
10+
channel = "1.81.0"
511
profile = "default"

0 commit comments

Comments
 (0)