Skip to content

Commit 75214e1

Browse files
authored
hyper v1: work around the current maghemite / omicron lag (#6706)
This is kind of gross. Omicron currently is out of sync with maghemite, see #6693 and the two maghemite pushes that require synchronization: oxidecomputer/maghemite#359 and oxidecomputer/maghemite#360. I'd like to make forward progress with the hyper v1 migration, and that's blocked on updating the omicron dependency of maghemite which pulls in old hyper (reqwest, progenitor, etc). This gets pull into other repos via omicron-common. It's worth noting that this circular arrangement seems lousy. The "vassal crates" (crucible, propolis, maghemite, (and dendrite to a lesser degree)) depend on omicron-common, but omicron-common pulls in maghemite's `mg-admin-client` which in turn pulls in... lots... including progenitor, hyper, reqwest, etc. My goal here is to have a temporary dependency on a branch of maghemite (oxidecomputer/maghemite#378); once #6693 is integrated, we can then pin the dependency on maghemite's HEAD rev.
1 parent 69da5d6 commit 75214e1

File tree

5 files changed

+33
-23
lines changed

5 files changed

+33
-23
lines changed

Cargo.lock

Lines changed: 7 additions & 7 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -422,8 +422,10 @@ macaddr = { version = "1.0.1", features = ["serde_std"] }
422422
maplit = "1.0.2"
423423
mockall = "0.13"
424424
newtype_derive = "0.1.6"
425-
mg-admin-client = { git = "https://github.com/oxidecomputer/maghemite", rev = "9e0fe45ca3862176dc31ad8cc83f605f8a7e1a42" }
426-
ddm-admin-client = { git = "https://github.com/oxidecomputer/maghemite", rev = "9e0fe45ca3862176dc31ad8cc83f605f8a7e1a42" }
425+
# mg-admin-client = { git = "https://github.com/oxidecomputer/maghemite", rev = "9e0fe45ca3862176dc31ad8cc83f605f8a7e1a42" }
426+
# ddm-admin-client = { git = "https://github.com/oxidecomputer/maghemite", rev = "9e0fe45ca3862176dc31ad8cc83f605f8a7e1a42" }
427+
mg-admin-client = { git = "https://github.com/oxidecomputer/maghemite", branch = "hyper-v1-no-merge" }
428+
ddm-admin-client = { git = "https://github.com/oxidecomputer/maghemite", branch = "hyper-v1-no-merge" }
427429
multimap = "0.10.0"
428430
nexus-auth = { path = "nexus/auth" }
429431
nexus-client = { path = "clients/nexus-client" }
@@ -527,7 +529,6 @@ ref-cast = "1.0"
527529
regex = "1.10.6"
528530
regress = "0.9.1"
529531
reqwest = { version = "0.12", default-features = false }
530-
reqwest11 = { package = "reqwest", version = "0.11", default-features = false }
531532
ring = "0.17.8"
532533
rpassword = "7.3.1"
533534
rstest = "0.22.0"

clients/ddm-admin-client/Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ workspace = true
1111
either.workspace = true
1212
progenitor-client.workspace = true
1313
reqwest = { workspace = true, features = ["json", "stream", "rustls-tls"] }
14-
reqwest11 = { workspace = true, features = ["json", "stream", "rustls-tls"] }
1514
serde.workspace = true
1615
slog.workspace = true
1716
thiserror.workspace = true

clients/ddm-admin-client/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ const DDMD_PORT: u16 = 8000;
3838
#[derive(Debug, Error)]
3939
pub enum DdmError {
4040
#[error("Failed to construct an HTTP client: {0}")]
41-
HttpClient(#[from] reqwest11::Error),
41+
HttpClient(#[from] reqwest::Error),
4242

4343
#[error("Failed making HTTP request to ddmd: {0}")]
4444
DdmdApi(#[from] Error<types::Error>),
@@ -64,7 +64,7 @@ impl Client {
6464
let log =
6565
log.new(slog::o!("DdmAdminClient" => SocketAddr::V6(ddmd_addr)));
6666

67-
let inner = reqwest11::ClientBuilder::new()
67+
let inner = reqwest::ClientBuilder::new()
6868
.connect_timeout(dur)
6969
.timeout(dur)
7070
.build()?;

workspace-hack/Cargo.toml

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ regex = { version = "1.10.6" }
9191
regex-automata = { version = "0.4.6", default-features = false, features = ["dfa", "hybrid", "meta", "nfa", "perf", "unicode"] }
9292
regex-syntax = { version = "0.8.4" }
9393
reqwest-5ef9efb8ec2df382 = { package = "reqwest", version = "0.12.7", features = ["blocking", "cookies", "json", "rustls-tls", "stream"] }
94-
reqwest-a6292c17cd707f01 = { package = "reqwest", version = "0.11.27", features = ["json", "rustls-tls", "stream"] }
94+
reqwest-a6292c17cd707f01 = { package = "reqwest", version = "0.11.27", default-features = false, features = ["rustls-tls", "stream"] }
9595
ring = { version = "0.17.8", features = ["std"] }
9696
rsa = { version = "0.9.6", features = ["serde", "sha2"] }
9797
schemars = { version = "0.8.21", features = ["bytes", "chrono", "uuid1"] }
@@ -202,7 +202,7 @@ regex = { version = "1.10.6" }
202202
regex-automata = { version = "0.4.6", default-features = false, features = ["dfa", "hybrid", "meta", "nfa", "perf", "unicode"] }
203203
regex-syntax = { version = "0.8.4" }
204204
reqwest-5ef9efb8ec2df382 = { package = "reqwest", version = "0.12.7", features = ["blocking", "cookies", "json", "rustls-tls", "stream"] }
205-
reqwest-a6292c17cd707f01 = { package = "reqwest", version = "0.11.27", features = ["json", "rustls-tls", "stream"] }
205+
reqwest-a6292c17cd707f01 = { package = "reqwest", version = "0.11.27", default-features = false, features = ["rustls-tls", "stream"] }
206206
ring = { version = "0.17.8", features = ["std"] }
207207
rsa = { version = "0.9.6", features = ["serde", "sha2"] }
208208
schemars = { version = "0.8.21", features = ["bytes", "chrono", "uuid1"] }
@@ -250,7 +250,8 @@ linux-raw-sys = { version = "0.4.13", default-features = false, features = ["elf
250250
mio = { version = "1.0.2", features = ["net", "os-ext"] }
251251
once_cell = { version = "1.19.0" }
252252
rustix = { version = "0.38.34", features = ["event", "fs", "net", "pipe", "process", "stdio", "system", "termios", "time"] }
253-
rustls = { version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
253+
rustls-2b5c6dc72f624058 = { package = "rustls", version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
254+
rustls-647d43efb71741da = { package = "rustls", version = "0.21.12", features = ["dangerous_configuration"] }
254255
signal-hook-mio = { version = "0.2.4", default-features = false, features = ["support-v0_8", "support-v1_0"] }
255256
tokio-rustls = { version = "0.26.0", default-features = false, features = ["logging", "ring", "tls12"] }
256257

@@ -264,7 +265,8 @@ linux-raw-sys = { version = "0.4.13", default-features = false, features = ["elf
264265
mio = { version = "1.0.2", features = ["net", "os-ext"] }
265266
once_cell = { version = "1.19.0" }
266267
rustix = { version = "0.38.34", features = ["event", "fs", "net", "pipe", "process", "stdio", "system", "termios", "time"] }
267-
rustls = { version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
268+
rustls-2b5c6dc72f624058 = { package = "rustls", version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
269+
rustls-647d43efb71741da = { package = "rustls", version = "0.21.12", features = ["dangerous_configuration"] }
268270
signal-hook-mio = { version = "0.2.4", default-features = false, features = ["support-v0_8", "support-v1_0"] }
269271
tokio-rustls = { version = "0.26.0", default-features = false, features = ["logging", "ring", "tls12"] }
270272

@@ -276,7 +278,8 @@ hyper-util = { version = "0.1.9", features = ["full"] }
276278
mio = { version = "1.0.2", features = ["net", "os-ext"] }
277279
once_cell = { version = "1.19.0" }
278280
rustix = { version = "0.38.34", features = ["event", "fs", "net", "pipe", "process", "stdio", "system", "termios", "time"] }
279-
rustls = { version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
281+
rustls-2b5c6dc72f624058 = { package = "rustls", version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
282+
rustls-647d43efb71741da = { package = "rustls", version = "0.21.12", features = ["dangerous_configuration"] }
280283
signal-hook-mio = { version = "0.2.4", default-features = false, features = ["support-v0_8", "support-v1_0"] }
281284
tokio-rustls = { version = "0.26.0", default-features = false, features = ["logging", "ring", "tls12"] }
282285

@@ -288,7 +291,8 @@ hyper-util = { version = "0.1.9", features = ["full"] }
288291
mio = { version = "1.0.2", features = ["net", "os-ext"] }
289292
once_cell = { version = "1.19.0" }
290293
rustix = { version = "0.38.34", features = ["event", "fs", "net", "pipe", "process", "stdio", "system", "termios", "time"] }
291-
rustls = { version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
294+
rustls-2b5c6dc72f624058 = { package = "rustls", version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
295+
rustls-647d43efb71741da = { package = "rustls", version = "0.21.12", features = ["dangerous_configuration"] }
292296
signal-hook-mio = { version = "0.2.4", default-features = false, features = ["support-v0_8", "support-v1_0"] }
293297
tokio-rustls = { version = "0.26.0", default-features = false, features = ["logging", "ring", "tls12"] }
294298

@@ -300,7 +304,8 @@ hyper-util = { version = "0.1.9", features = ["full"] }
300304
mio = { version = "1.0.2", features = ["net", "os-ext"] }
301305
once_cell = { version = "1.19.0" }
302306
rustix = { version = "0.38.34", features = ["event", "fs", "net", "pipe", "process", "stdio", "system", "termios", "time"] }
303-
rustls = { version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
307+
rustls-2b5c6dc72f624058 = { package = "rustls", version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
308+
rustls-647d43efb71741da = { package = "rustls", version = "0.21.12", features = ["dangerous_configuration"] }
304309
signal-hook-mio = { version = "0.2.4", default-features = false, features = ["support-v0_8", "support-v1_0"] }
305310
tokio-rustls = { version = "0.26.0", default-features = false, features = ["logging", "ring", "tls12"] }
306311

@@ -312,7 +317,8 @@ hyper-util = { version = "0.1.9", features = ["full"] }
312317
mio = { version = "1.0.2", features = ["net", "os-ext"] }
313318
once_cell = { version = "1.19.0" }
314319
rustix = { version = "0.38.34", features = ["event", "fs", "net", "pipe", "process", "stdio", "system", "termios", "time"] }
315-
rustls = { version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
320+
rustls-2b5c6dc72f624058 = { package = "rustls", version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
321+
rustls-647d43efb71741da = { package = "rustls", version = "0.21.12", features = ["dangerous_configuration"] }
316322
signal-hook-mio = { version = "0.2.4", default-features = false, features = ["support-v0_8", "support-v1_0"] }
317323
tokio-rustls = { version = "0.26.0", default-features = false, features = ["logging", "ring", "tls12"] }
318324

@@ -325,8 +331,10 @@ hyper-util = { version = "0.1.9", features = ["full"] }
325331
indicatif = { version = "0.17.8", features = ["rayon"] }
326332
mio = { version = "1.0.2", features = ["net", "os-ext"] }
327333
once_cell = { version = "1.19.0" }
334+
reqwest-a6292c17cd707f01 = { package = "reqwest", version = "0.11.27", features = ["json"] }
328335
rustix = { version = "0.38.34", features = ["event", "fs", "net", "pipe", "process", "stdio", "system", "termios", "time"] }
329-
rustls = { version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
336+
rustls-2b5c6dc72f624058 = { package = "rustls", version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
337+
rustls-647d43efb71741da = { package = "rustls", version = "0.21.12", features = ["dangerous_configuration"] }
330338
signal-hook-mio = { version = "0.2.4", default-features = false, features = ["support-v0_8", "support-v1_0"] }
331339
tokio-rustls = { version = "0.26.0", default-features = false, features = ["logging", "ring", "tls12"] }
332340
toml_edit-cdcf2f9584511fe6 = { package = "toml_edit", version = "0.19.15", features = ["serde"] }
@@ -340,8 +348,10 @@ hyper-util = { version = "0.1.9", features = ["full"] }
340348
indicatif = { version = "0.17.8", features = ["rayon"] }
341349
mio = { version = "1.0.2", features = ["net", "os-ext"] }
342350
once_cell = { version = "1.19.0" }
351+
reqwest-a6292c17cd707f01 = { package = "reqwest", version = "0.11.27", features = ["json"] }
343352
rustix = { version = "0.38.34", features = ["event", "fs", "net", "pipe", "process", "stdio", "system", "termios", "time"] }
344-
rustls = { version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
353+
rustls-2b5c6dc72f624058 = { package = "rustls", version = "0.23.10", default-features = false, features = ["logging", "ring", "std", "tls12"] }
354+
rustls-647d43efb71741da = { package = "rustls", version = "0.21.12", features = ["dangerous_configuration"] }
345355
signal-hook-mio = { version = "0.2.4", default-features = false, features = ["support-v0_8", "support-v1_0"] }
346356
tokio-rustls = { version = "0.26.0", default-features = false, features = ["logging", "ring", "tls12"] }
347357
toml_edit-cdcf2f9584511fe6 = { package = "toml_edit", version = "0.19.15", features = ["serde"] }

0 commit comments

Comments
 (0)