Skip to content

Bump max instance RAM to 1024 GiB #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2025
Merged

Bump max instance RAM to 1024 GiB #2825

merged 2 commits into from
May 19, 2025

Conversation

david-crespo
Copy link
Collaborator

@david-crespo david-crespo commented May 15, 2025 •
edited
Loading

Closes #2824

Turns out we don't have any tests exercising these limits, and while testing it I noticed that we do something really annoying on instance create if you type in too big of a RAM amount. Unlike in the resize modal, where we correctly show an error on blur, on instance create we just silently change the value to the max.

image

@vercel Vercel
Copy link

vercel bot commented May 15, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
console ✅ Ready (Inspect) Visit Preview May 15, 2025 9:38pm

@david-crespo
Copy link
Collaborator Author

The minValue and maxValue props can be used to limit the entered value to a specific range. The value will be clamped when the user blurs the input field.

https://react-spectrum.adobe.com/react-aria/useNumberField.html#minimum-and-maximum-values

The difference between instance create and resize is that we are not passing max in the resize one (relying solely on the explicit validation function to validate on blur) so it is not doing the clamping. The downside here is that the up button doesn't get disabled when you reach the max, which is cute. If forced to choose, I'd rather have validate on blur than disabled button, but I'll see if we can get both.

@david-crespo david-crespo marked this pull request as ready for review May 15, 2025 21:38
@david-crespo
Copy link
Collaborator Author

Tolerable IMO even though the up button (and up arrow key) isn't disabled. At these numbers you're probably not using them anyway.

image

@david-crespo
Copy link
Collaborator Author

Merging as net improvement, we can figure out the other thing later if we care

@david-crespo david-crespo merged commit a186ae6 into main May 19, 2025
7 checks passed
@david-crespo david-crespo deleted the bump-max-ram branch May 19, 2025 15:47
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Jun 4, 2025
@david-crespo
Bump web console (my access tokens page)
54e16dd 
oxidecomputer/console@46e244f...e891f96

* [e891f968](oxidecomputer/console@e891f968) oxidecomputer/console#2833
* [f2584554](oxidecomputer/console@f2584554) oxidecomputer/console#2832
* [a186ae6f](oxidecomputer/console@a186ae6f) oxidecomputer/console#2825
* [a480ca7f](oxidecomputer/console@a480ca7f) tools: api-diff: switch from difftastic to delta
* [ad05de96](oxidecomputer/console@ad05de96) tools: api-diff comment fix
* [77d5849d](oxidecomputer/console@77d5849d) tools: fix api-diff to get more precise PR base commit
* [f8c05f20](oxidecomputer/console@f8c05f20) oxidecomputer/console#2808
* [50a84bc1](oxidecomputer/console@50a84bc1) bump omicron to latest main for webhook secret timestamp
@david-crespo david-crespo mentioned this pull request Jun 4, 2025
Merged
david-crespo added a commit to oxidecomputer/omicron that referenced this pull request Jun 4, 2025
@david-crespo
Bump web console (my access tokens page) (#8267)
299b3ce 
oxidecomputer/console@46e244f...e891f96

* [e891f968](oxidecomputer/console@e891f968)
oxidecomputer/console#2833
* [f2584554](oxidecomputer/console@f2584554)
oxidecomputer/console#2832
* [a186ae6f](oxidecomputer/console@a186ae6f)
oxidecomputer/console#2825
* [a480ca7f](oxidecomputer/console@a480ca7f)
tools: api-diff: switch from difftastic to delta
* [ad05de96](oxidecomputer/console@ad05de96)
tools: api-diff comment fix
* [77d5849d](oxidecomputer/console@77d5849d)
tools: fix api-diff to get more precise PR base commit
* [f8c05f20](oxidecomputer/console@f8c05f20)
oxidecomputer/console#2808
* [50a84bc1](oxidecomputer/console@50a84bc1)
bump omicron to latest main for webhook secret timestamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@charliepark charliepark charliepark approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump up maximum VM memory size to 1024 GiB
2 participants
@david-crespo @charliepark