Skip to content

Commit fd82458

Browse files
authored
Give pagination bar the same z-index as topbar (#2457)
* give pagination bar the same z-index as topbar * fix e2e test
1 parent 7daaa33 commit fd82458

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

app/layouts/helpers.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ export function ContentPane() {
2727
<Outlet />
2828
</main>
2929
</div>
30-
<div className="sticky bottom-0 shrink-0 justify-between overflow-hidden border-t bg-default border-secondary empty:border-t-0">
30+
<div className="sticky bottom-0 z-topBar shrink-0 justify-between overflow-hidden border-t bg-default border-secondary empty:border-t-0">
3131
<Pagination.Target />
3232
<PageActionsTarget />
3333
</div>

test/e2e/snapshots.e2e.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,10 @@ test('Confirm delete snapshot', async ({ page }) => {
3030

3131
const row = page.getByRole('row', { name: 'disk-1-snapshot-6' })
3232

33+
// scroll a little so the dropdown menu isn't behind the pagination bar
34+
await page.getByRole('table').click() // focus the content pane
35+
await page.mouse.wheel(0, 200)
36+
3337
async function clickDelete() {
3438
await row.getByRole('button', { name: 'Row actions' }).click()
3539
await page.getByRole('menuitem', { name: 'Delete' }).click()

0 commit comments

Comments
 (0)