File tree 2 files changed +16
-22
lines changed 2 files changed +16
-22
lines changed Original file line number Diff line number Diff line change @@ -916,16 +916,11 @@ impl<
916
916
if position != 0xffff_ffff && position != 0
917
917
/* sigh. Some images have 0 as "invalid" mark */
918
918
{
919
- return match BhdDirectory :: load (
919
+ return BhdDirectory :: load (
920
920
self . storage ,
921
921
position,
922
922
self . amd_physical_mode_mmio_size ,
923
- ) {
924
- Ok ( e) => Some ( e) ,
925
- Err ( e) => {
926
- None // FIXME: error check
927
- }
928
- } ;
923
+ ) . ok ( ) // FIXME: error check
929
924
}
930
925
}
931
926
None
Original file line number Diff line number Diff line change @@ -449,21 +449,20 @@ impl ValueOrLocation {
449
449
directory_address_mode,
450
450
AddressMode :: PhysicalAddress
451
451
) {
452
- /* AMD retrofitted (introduced) two
453
- flag bits at the top bits in Milan.
454
-
455
- In Rome, you actually COULD use
456
- all the bits.
457
-
458
- Newer platform do not regularily use
459
- AddressMode::PhysicalAddress anyway.
460
-
461
- But if someone uses
462
- AddressMode::PhysicalAddress,
463
- they might do it on Rome and use
464
- those two top bits as part of the
465
- address.
466
- */
452
+ // AMD retrofitted (introduced) two
453
+ // flag bits at the top bits in Milan.
454
+ //
455
+ // In Rome, you actually COULD use
456
+ // all the bits.
457
+ //
458
+ // Newer platform do not regularily use
459
+ // AddressMode::PhysicalAddress anyway.
460
+ //
461
+ // But if someone uses
462
+ // AddressMode::PhysicalAddress,
463
+ // they might do it on Rome and use
464
+ // those two top bits as part of the
465
+ // address.
467
466
let v = u64:: from ( * x) ;
468
467
Ok ( v)
469
468
} else {
You can’t perform that action at this time.
0 commit comments