cleanup: get clippy clean

Also use a workspace for `xtask`.

Signed-off-by: Dan Cross <[email protected]>

Author: dancrossnyc

Cargo.toml

@@ -1,3 +1,5 @@
+workspace = { members = [ "xtask" ] }
+
 [package]
 name = "amd-apcb"
 version = "0.5.1"

src/apcb.rs

@@ -120,7 +120,7 @@ pub struct SerdeApcb {
 }
 
 #[cfg(feature = "schemars")]
-impl<'a> schemars::JsonSchema for Apcb<'a> {
+impl schemars::JsonSchema for Apcb<'_> {
     fn schema_name() -> std::string::String {
         SerdeApcb::schema_name()
     }
@@ -135,7 +135,7 @@ impl<'a> schemars::JsonSchema for Apcb<'a> {
 }
 
 #[cfg(feature = "serde")]
-impl<'a> Apcb<'a> {
+impl Apcb<'_> {
     pub fn context(&self) -> ApcbContext {
         self.context
     }
@@ -197,7 +197,7 @@ impl<'a> Apcb<'a> {
 }
 
 #[cfg(feature = "serde")]
-impl<'a> Serialize for Apcb<'a> {
+impl Serialize for Apcb<'_> {
     fn serialize<S>(
         &self,
         serializer: S,

src/entry.rs

@@ -173,8 +173,8 @@ impl<'a, T: EntryCompatible + MutSequenceElementFromBytes<'a>>
     }
 }
 
-impl<'a, 'b, T: EntryCompatible + MutSequenceElementFromBytes<'b>>
-    StructSequenceEntryMutIter<'a, T>
+impl<'b, T: EntryCompatible + MutSequenceElementFromBytes<'b>>
+    StructSequenceEntryMutIter<'_, T>
 {
     pub(crate) fn validate(mut self) -> Result<()> {
         while !self.buf.is_empty() {
@@ -438,7 +438,7 @@ pub struct SerdeEntryItem {
 }
 
 #[cfg(feature = "schemars")]
-impl<'a> schemars::JsonSchema for EntryItem<'a> {
+impl schemars::JsonSchema for EntryItem<'_> {
     fn schema_name() -> std::string::String {
         String::from("EntryItem")
     }
@@ -631,7 +631,7 @@ impl schemars::JsonSchema for SerdeEntryItem {
 }
 
 #[cfg(feature = "serde")]
-impl<'a> Serialize for EntryItem<'a> {
+impl Serialize for EntryItem<'_> {
     fn serialize<S>(
         &self,
         serializer: S,
@@ -1031,7 +1031,7 @@ impl<'de> Deserialize<'de> for SerdeEntryItem {
             {
                 struct FieldVisitor;
 
-                impl<'de> Visitor<'de> for FieldVisitor {
+                impl Visitor<'_> for FieldVisitor {
                     type Value = Field;
 
                     fn expecting(

src/group.rs

@@ -44,7 +44,7 @@ pub struct SerdeGroupItem {
 }
 
 #[cfg(feature = "schemars")]
-impl<'a> schemars::JsonSchema for GroupItem<'a> {
+impl schemars::JsonSchema for GroupItem<'_> {
     fn schema_name() -> std::string::String {
         SerdeGroupItem::schema_name()
     }
@@ -249,7 +249,7 @@ pub struct GroupMutIter<'a> {
     remaining_used_size: usize,
 }
 
-impl<'a> GroupMutIter<'a> {
+impl GroupMutIter<'_> {
     /// It's useful to have some way of NOT mutating self.buf.  This is what
     /// this function does. Note: The caller needs to manually decrease
     /// remaining_used_size for each call if desired.
@@ -503,7 +503,7 @@ pub struct GroupMutItem<'a> {
     pub(crate) used_size: usize,
 }
 
-impl<'a> GroupMutItem<'a> {
+impl GroupMutItem<'_> {
     /// Note: ASCII
     pub fn signature(&self) -> [u8; 4] {
         self.header.signature

src/ondisk.rs

@@ -8848,7 +8848,7 @@ impl<'de> serde::Deserialize<'de> for FchConsoleOutMode {
         deserializer: D,
     ) -> std::result::Result<Self, D::Error> {
         struct ModeVisitor;
-        impl<'de> serde::de::Visitor<'de> for ModeVisitor {
+        impl serde::de::Visitor<'_> for ModeVisitor {
             type Value = FchConsoleOutMode;
             fn expecting(
                 &self,
@@ -11676,7 +11676,7 @@ make_token_accessors! {
 
 // Compatibility shim for old token accessors (which we have a lot of
 // configurations with)
-impl<'a, 'b> Tokens<'a, 'b> {
+impl Tokens<'_, '_> {
     #[allow(non_snake_case)]
     pub fn mem_limit_memory_to_below_1_TiB(&self) -> Result<bool> {
         bool::from_u32(self.get(TokenEntryId::Bool, 0x5e71e6d8)?)
@@ -11723,7 +11723,7 @@ impl<'a, 'b> Tokens<'a, 'b> {
 
 // Compatibility shim for old token accessors (which we have a lot of
 // configurations with)
-impl<'a, 'b> TokensMut<'a, 'b> {
+impl TokensMut<'_, '_> {
     #[allow(non_snake_case)]
     pub fn mem_limit_memory_to_below_1_TiB(&self) -> Result<bool> {
         bool::from_u32(self.get(TokenEntryId::Bool, 0x5e71e6d8)?)