Skip to content

Commit e8277e8

Browse files
committed
test(ast/estree): ignore field order difference from typescript-eslint (#9813)
Part of #9705 This doesn't magically improve passes, but it makes it easier to digest mismatch diff. <details><summary>tasks/coverage/acorn-test262-diff/typescript/tests/cases/compiler/2dArrays.diff</summary> ```diff @@ -20,12 +20,12 @@ "type": "Identifier", "start": 6, "end": 10, - "decorators": [], - "name": "Cell", - "optional": false + "name": "Cell" }, - "implements": [], - "superClass": null + "implements": null, + "superClass": null, + "superTypeParameters": null, + "typeParameters": null }, { "type": "ClassDeclaration", @@ -41,6 +41,7 @@ "type": "PropertyDefinition", "start": 33, "end": 49, + "accessibility": null, "computed": false, "declare": false, "decorators": [], @@ -49,9 +50,7 @@ "type": "Identifier", "start": 33, "end": 39, - "decorators": [], - "name": "isSunk", - "optional": false + "name": "isSunk" }, "optional": false, "override": false, @@ -77,12 +76,12 @@ "type": "Identifier", "start": 22, "end": 26, - "decorators": [], - "name": "Ship", - "optional": false + "name": "Ship" }, - "implements": [], - "superClass": null + "implements": null, + "superClass": null, + "superTypeParameters": null, + "typeParameters": null }, { "type": "ClassDeclaration", @@ -98,6 +97,7 @@ "type": "PropertyDefinition", "start": 71, "end": 85, + "accessibility": null, "computed": false, "declare": false, "decorators": [], @@ -106,9 +106,7 @@ "type": "Identifier", "start": 71, "end": 76, - "decorators": [], - "name": "ships", - "optional": false + "name": "ships" }, "optional": false, "override": false, @@ -130,10 +128,9 @@ "type": "Identifier", "start": 78, "end": 82, - "decorators": [], - "name": "Ship", - "optional": false - } + "name": "Ship" + }, + "typeParameters": null } } }, @@ -143,6 +140,7 @@ "type": "PropertyDefinition", "start": 90, "end": 104, + "accessibility": null, "computed": false, "declare": false, "decorators": [], @@ -151,9 +149,7 @@ "type": "Identifier", "start": 90, "end": 95, - "decorators": [], - "name": "cells", - "optional": false + "name": "cells" }, "optional": false, "override": false, @@ -175,10 +171,9 @@ "type": "Identifier", "start": 97, "end": 101, - "decorators": [], - "name": "Cell", - "optional": false - } + "name": "Cell" + }, + "typeParameters": null } } }, @@ -195,9 +190,7 @@ "type": "Identifier", "start": 118, "end": 130, - "decorators": [], - "name": "allShipsSunk", - "optional": false + "name": "allShipsSunk" }, "kind": "method", "optional": false, @@ -245,18 +238,14 @@ "type": "Identifier", "start": 191, "end": 194, - "decorators": [], - "name": "val", - "optional": false + "name": "val" }, "optional": false, "property": { "type": "Identifier", "start": 195, "end": 201, - "decorators": [], - "name": "isSunk", - "optional": false + "name": "isSunk" } } } @@ -271,11 +260,18 @@ "type": "Identifier", "start": 177, "end": 180, + "accessibility": null, "decorators": [], "name": "val", - "optional": false + "optional": false, + "override": false, + "readonly": false, + "typeAnnotation": null } - ] + ], + "returnType": null, + "thisParam": null, + "typeParameters": null } ], "callee": { @@ -298,9 +294,7 @@ "type": "Identifier", "start": 155, "end": 160, - "decorators": [], - "name": "ships", - "optional": false + "name": "ships" } }, "optional": false, @@ -308,12 +302,11 @@ "type": "Identifier", "start": 161, "end": 166, - "decorators": [], - "name": "every", - "optional": false + "name": "every" } }, - "optional": false + "optional": false, + "typeParameters": null } } ] @@ -322,7 +315,10 @@ "expression": false, "generator": false, "id": null, - "params": [] + "params": [], + "returnType": null, + "thisParam": null, + "typeParameters": null } } ] @@ -333,12 +329,12 @@ "type": "Identifier", "start": 59, "end": 64, - "decorators": [], - "name": "Board", - "optional": false + "name": "Board" }, - "implements": [], - "superClass": null + "implements": null, + "superClass": null, + "superTypeParameters": null, + "typeParameters": null } ], "sourceType": "script", ``` </details> It slows down a bit, but not so much?
1 parent 7da3124 commit e8277e8

File tree

2 files changed

+94
-53
lines changed

2 files changed

+94
-53
lines changed

0 commit comments

Comments
 (0)