test(ast/estree): ignore serde_json errors (#10660)

Related to #9705. Ignore errors from `serde_json` failing to parse JSON AST from `acorn-test262` TS-ESLint parser fixtures.

These errors are due to deficiencies in `serde_json` and don't represent real problems.

When we switch over to comparing ASTs as JSON strings (as we do in the Acorn and JSX tests), these problems should disappear.

Author: overlookmotel

tasks/coverage/snapshots/estree_typescript.snap

@@ -2,15 +2,12 @@ commit: 15392346
 
 estree_typescript Summary:
 AST Parsed     : 6489/6493 (99.94%)
-Positive Passed: 6458/6493 (99.46%)
+Positive Passed: 6470/6493 (99.65%)
 Expect to Parse: tasks/coverage/typescript/tests/cases/compiler/arrayFromAsync.ts
 `await` is only allowed within async functions and at the top levels of modules
 
 Mismatch: tasks/coverage/typescript/tests/cases/compiler/controlFlowInstanceofWithSymbolHasInstance.ts
 
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/compiler/deferredConditionalTypes2.ts
-number out of range at line 28 column 25
-
 Mismatch: tasks/coverage/typescript/tests/cases/compiler/emitBundleWithShebang1.ts
 
 Mismatch: tasks/coverage/typescript/tests/cases/compiler/emitBundleWithShebang2.ts
@@ -19,17 +16,8 @@ Mismatch: tasks/coverage/typescript/tests/cases/compiler/emitBundleWithShebangAn
 
 Mismatch: tasks/coverage/typescript/tests/cases/compiler/emitBundleWithShebangAndPrologueDirectives2.ts
 
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/compiler/fakeInfinity2.ts
-number out of range at line 46 column 31
-
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/compiler/fakeInfinity3.ts
-number out of range at line 46 column 31
-
 Mismatch: tasks/coverage/typescript/tests/cases/compiler/narrowingUnionToUnion.ts
 
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/compiler/parsingDeepParenthensizedExpression.ts
-recursion limit exceeded at line 3334 column 269
-
 Mismatch: tasks/coverage/typescript/tests/cases/compiler/shebang.ts
 
 Mismatch: tasks/coverage/typescript/tests/cases/compiler/shebangBeforeReferences.ts
@@ -43,32 +31,8 @@ Classes may not have a static property named prototype
 Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/es2019/importMeta/importMeta.ts
 The only valid meta property for import is import.meta
 
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/conformance/es6/binaryAndOctalIntegerLiteral/binaryIntegerLiteral.ts
-number out of range at line 129 column 27
-
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/conformance/es6/binaryAndOctalIntegerLiteral/binaryIntegerLiteralES6.ts
-number out of range at line 129 column 27
-
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/conformance/es6/binaryAndOctalIntegerLiteral/octalIntegerLiteral.ts
-number out of range at line 96 column 27
-
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/conformance/es6/binaryAndOctalIntegerLiteral/octalIntegerLiteralES6.ts
-number out of range at line 96 column 27
-
 Mismatch: tasks/coverage/typescript/tests/cases/conformance/es6/templates/templateStringMultiline3.ts
 
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/conformance/es6/unicodeExtendedEscapes/unicodeExtendedEscapesInStrings10.ts
-unexpected end of hex escape at line 30 column 29
-
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/conformance/es6/unicodeExtendedEscapes/unicodeExtendedEscapesInStrings11.ts
-lone leading surrogate in hex escape at line 30 column 28
-
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/conformance/es6/unicodeExtendedEscapes/unicodeExtendedEscapesInTemplates10.ts
-unexpected end of hex escape at line 38 column 36
-
-serde_json::from_str(oxc_json) Error: tasks/coverage/typescript/tests/cases/conformance/es6/unicodeExtendedEscapes/unicodeExtendedEscapesInTemplates11.ts
-lone leading surrogate in hex escape at line 38 column 35
-
 Expect to Parse: tasks/coverage/typescript/tests/cases/conformance/esDecorators/esDecorators-decoratorExpression.1.ts
 Expected a semicolon or an implicit semicolon after a statement, but found none
 

tasks/coverage/src/tools/estree.rs

@@ -322,7 +322,15 @@ impl Case for EstreeTypescriptCase {
 
             let oxc_json = program.to_pretty_estree_ts_json();
 
-            // Compare as objects to ignore field order differences for now
+            // Compare as objects to ignore field order differences for now.
+            //
+            // Also ignore failure to parse ESTree JSON. These failures are just due to `serde` being
+            // unable to handle lone surrogates in strings and numbers which are to big to fit in an `f64`.
+            // These should match once we switch to comparing ASTs as JSON strings.
+            let Ok(estree_json_value) = serde_json::from_str::<serde_json::Value>(estree_json)
+            else {
+                continue;
+            };
             let mut oxc_json_value = match serde_json::from_str::<serde_json::Value>(&oxc_json) {
                 Ok(v) => v,
                 Err(e) => {
@@ -331,16 +339,6 @@ impl Case for EstreeTypescriptCase {
                     return;
                 }
             };
-            let estree_json_value = match serde_json::from_str::<serde_json::Value>(estree_json) {
-                Ok(v) => v,
-                Err(e) => {
-                    self.base.result = TestResult::GenericError(
-                        "serde_json::from_str(estree_json)",
-                        e.to_string(),
-                    );
-                    return;
-                }
-            };
             if oxc_json_value == estree_json_value {
                 continue;
             }