Skip to content

Support extends in buildFromOxlintConfigFile #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ValentinGurkov opened this issue Apr 12, 2025 · 2 comments · Fixed by #419
Closed

Support extends in buildFromOxlintConfigFile #386

ValentinGurkov opened this issue Apr 12, 2025 · 2 comments · Fixed by #419

Comments

@ValentinGurkov
Copy link

Hello,

Thank you for providing this plugin, it makes the transition to oxlint much smoother!
We use oxlint in a monorepo scenario where we extend a base configuration. I debugged buildFromOxlintConfigFile and found that it only reads info about rules, plugins etc. from the current config and doesn't follow through the chain of extends.
There is a pretty simple workaround by also adding another line of buildFromOxlintConfigFile with the base config, though I was wondering if supporting extends is something you'd be interested in?

@Sysix
Copy link
Member

Sysix commented Apr 12, 2025

though I was wondering if supporting extends is something you'd be interested in?

Yes, we want to support this. extends came later, and I had no time to implement it.
Feel free to create a PR :)

@yunarch
Copy link
Contributor

yunarch commented May 19, 2025

@ValentinGurkov We also need this feature so I have created a PR #419 with an initial implementation

@Sysix The implementation can be improved, but I think is a starting point 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants