chore(playwright): add tests

Author: zikani03

executors/playwright/actions.go

@@ -13,6 +13,7 @@ type ActionFunc func(page playwrightgo.Page, element string, target ...any) erro
 var actionMap = map[string]ActionFunc{
 	"Click":             ClickAction,
 	"DoubleClick":       DoubleClickAction,
+	"Doubleclick":       DoubleClickAction,
 	"Tap":               TapAction,
 	"Focus":             FocusAction,
 	"Blur":              BlurAction,

executors/playwright/playwright.go

@@ -103,7 +103,7 @@ func (Executor) Run(ctx context.Context, step venom.TestStep) (interface{}, erro
 		return nil, fmt.Errorf("could not goto: %w", err)
 	}
 
-	err = performActions(page, e.Actions)
+	err = performActions(ctx, page, e.Actions)
 	if err != nil {
 		return nil, err
 	}
@@ -112,7 +112,6 @@ func (Executor) Run(ctx context.Context, step venom.TestStep) (interface{}, erro
 	if err != nil {
 		return nil, fmt.Errorf("could not goto: %w", err)
 	}
-	// TODO: run the assertions in here ...
 
 	err = browser.Close()
 	if err != nil {
@@ -135,25 +134,44 @@ func (Executor) Run(ctx context.Context, step venom.TestStep) (interface{}, erro
 	}, nil
 }
 
-func performActions(page playwrightgo.Page, actions []string) error {
+// parseActionLine parses a line containing an Action expression and returns
+// the actionName, the arguments (rest of the line), the actionFunc or an error
+func parseActionLine(actionLine string) (string, string, ActionFunc, error) {
+	if actionLine == "" {
+		return "", "", nil, fmt.Errorf("action line MUST not be empty")
+	}
+	parts := strings.SplitN(strings.TrimSpace(actionLine), " ", 2)
+	if len(parts) < 2 {
+		return "", "", nil, fmt.Errorf("action line MUST have atleast two arguments: ACTION <selector>")
+	}
+	actionName, arguments := parts[0], parts[1]
+	actionFunc, ok := actionMap[actionName]
+	if !ok {
+		return "", "", nil, fmt.Errorf("invalid or unsupported action specified '%s'", actionName)
+	}
+	return actionName, arguments, actionFunc, nil
+}
+
+func performActions(ctx context.Context, page playwrightgo.Page, actions []string) error {
 	for _, action := range actions {
-		fmt.Println("perform action step", action)
-		parts := strings.SplitN(strings.TrimSpace(action), " ", 2)
-		actionName, arguments := parts[0], parts[1]
-		actionFunc, ok := actionMap[actionName]
-		if !ok {
-			return fmt.Errorf("invalid or unsupported action specified '%s'", actionName)
+		actionName, arguments, actionFunc, err := parseActionLine(action)
+		if err != nil {
+			return err
 		}
+
+		venom.Debug(ctx, fmt.Sprintf("perform action '%s' with arguments '%v'\n", actionName, arguments))
+
 		selectorAndArgs := strings.SplitN(strings.TrimSpace(arguments), " ", 2)
 		selector := removeQuotes(selectorAndArgs[0])
-		var err error
+
+		var actErr error
 		if len(selectorAndArgs) <= 1 {
-			err = actionFunc(page, selector, nil)
+			actErr = actionFunc(page, selector, nil)
 		} else {
-			err = actionFunc(page, selector, removeQuotes(selectorAndArgs[1]))
+			actErr = actionFunc(page, selector, removeQuotes(selectorAndArgs[1]))
 		}
-		if err != nil {
-			return err
+		if actErr != nil {
+			return actErr
 		}
 	}
 	return nil

executors/playwright/playwright_test.go

@@ -0,0 +1,59 @@
+package playwright
+
+import (
+	"testing"
+)
+
+func TestParseValidActionLines(t *testing.T) {
+	testCases := []struct {
+		ActionLine string
+		Action     string // expected action
+	}{
+		{ActionLine: `Click "some-element"`, Action: "Click"},
+		{ActionLine: `DoubleClick "some-element"`, Action: "DoubleClick"},
+		{ActionLine: `Doubleclick "some-element"`, Action: "Doubleclick"},
+		{ActionLine: `Tap "some-element"`, Action: "Tap"},
+		{ActionLine: `Focus "some-element"`, Action: "Focus"},
+		{ActionLine: `Blur "some-element"`, Action: "Blur"},
+		{ActionLine: `Clear "some-element"`, Action: "Clear"},
+		{ActionLine: `Check "some-element"`, Action: "Check"},
+		{ActionLine: `Uncheck "some-element"`, Action: "Uncheck"},
+		{ActionLine: `Fill "some-element" "some text"`, Action: "Fill"},
+		{ActionLine: `Press "some-element"`, Action: "Press"},
+		{ActionLine: `Type "some-element"`, Action: "Type"},
+	}
+
+	for _, tc := range testCases {
+		if action, _, _, err := parseActionLine(tc.ActionLine); err != nil {
+			t.Errorf("failed to parse action, got error '%v'", err)
+		} else {
+			if action != tc.Action {
+				t.Errorf("failed to parse action, expected '%s' but got '%s'", tc.Action, action)
+			}
+		}
+	}
+}
+
+func TestParseInvalidActionLines(t *testing.T) {
+	testCases := []string{
+		``,
+		`Click`,
+		`Clickit "some-element"`,
+		`Double-Click "some-element"`,
+		`Double click "some-element"`,
+		`Taps"some-element"`,
+		`Focuses "some-element"`,
+		`Blurs "some-element"`,
+		`Cleare "some-element"`,
+		`Checked "some-element"`,
+		`Unchecked "some-element"`,
+		`Pressed "some-element"`,
+		`Typed "some-element"`,
+	}
+
+	for _, tc := range testCases {
+		if _, _, _, err := parseActionLine(tc); err == nil {
+			t.Errorf("failed to parse action, expected error but got none for '%s'", tc)
+		}
+	}
+}