format llm error when serving over http

Author: Marlinski

shai-http/src/apis/openai/completion/formatter.rs

@@ -61,17 +61,30 @@ impl EventFormatter for ChatCompletionFormatter {
         match event {
             // Capture assistant messages from brain results
             AgentEvent::BrainResult { thought, .. } => {
-                if let Ok(msg) = thought {
-                    if let ChatMessage::Assistant {
-                        content: Some(ChatMessageContent::Text(text)),
-                        ..
-                    } = msg
-                    {
-                        // Accumulate the text for final response
-                        self.accumulated_text = text;
+                match thought {
+                    Ok(msg) => {
+                        if let ChatMessage::Assistant {
+                            content: Some(ChatMessageContent::Text(text)),
+                            ..
+                        } = msg
+                        {
+                            // Accumulate the text for final response
+                            self.accumulated_text = text;
+                        }
+                        None
+                    }
+                    Err(err) => {
+                        // Stream error as assistant message
+                        let delta = DeltaChatMessage::Assistant {
+                            content: Some(ChatMessageContent::Text(format!("Error: {}", err))),
+                            reasoning_content: None,
+                            refusal: None,
+                            name: None,
+                            tool_calls: None,
+                        };
+                        Some(self.create_chunk(delta, Some(FinishReason::StopSequenceReached)))
                     }
                 }
-                None
             }
 
             // Tool call started - stream as thinking delta

shai-http/src/apis/openai/response/formatter.rs

@@ -114,13 +114,19 @@ impl EventFormatter for ResponseFormatter {
         match event {
             // Capture assistant messages from brain results
             AgentEvent::BrainResult { thought, .. } => {
-                if let Ok(msg) = thought {
-                    if let ChatMessage::Assistant {
-                        content: Some(ChatMessageContent::Text(text)),
-                        ..
-                    } = msg
-                    {
-                        self.accumulated_text = text;
+                match thought {
+                    Ok(msg) => {
+                        if let ChatMessage::Assistant {
+                            content: Some(ChatMessageContent::Text(text)),
+                            ..
+                        } = msg
+                        {
+                            self.accumulated_text = text;
+                        }
+                    }
+                    Err(err) => {
+                        // Accumulate error message as text
+                        self.accumulated_text = format!("Error: {}", err);
                     }
                 }
                 None

shai-http/src/apis/simple/formatter.rs

@@ -28,27 +28,39 @@ impl EventFormatter for SimpleFormatter {
     ) -> Option<Self::Output> {
         match event {
             AgentEvent::BrainResult { thought, .. } => {
-                if let Ok(msg) = thought {
-                    // Extract text content from the ChatMessage
-                    let text_content = match &msg {
-                        ChatMessage::Assistant {
-                            content: Some(ChatMessageContent::Text(text)),
-                            ..
-                        } => Some(text.clone()),
-                        _ => None,
-                    };
+                match thought {
+                    Ok(msg) => {
+                        // Extract text content from the ChatMessage
+                        let text_content = match &msg {
+                            ChatMessage::Assistant {
+                                content: Some(ChatMessageContent::Text(text)),
+                                ..
+                            } => Some(text.clone()),
+                            _ => None,
+                        };
 
-                    if let Some(text) = text_content {
-                        return Some(MultiModalStreamingResponse {
+                        if let Some(text) = text_content {
+                            return Some(MultiModalStreamingResponse {
+                                id: session_id.to_string(),
+                                model: self.model.clone(),
+                                assistant: Some(text),
+                                call: None,
+                                result: None,
+                            });
+                        }
+                        None
+                    }
+                    Err(err) => {
+                        // Format error as assistant message
+                        Some(MultiModalStreamingResponse {
                             id: session_id.to_string(),
                             model: self.model.clone(),
-                            assistant: Some(text),
+                            assistant: Some(format!("Error: {}", err)),
                             call: None,
                             result: None,
-                        });
+                        })
                     }
                 }
-                None
             }
             AgentEvent::ToolCallStarted { call, .. } => Some(MultiModalStreamingResponse {
                 id: session_id.to_string(),