feat(okms): display default max versions in secret manager settings form

ref: #MANAGER-17868

Signed-off-by: Mathieu Mousnier <[email protected]>

Author: mathieumousnier

packages/manager/apps/okms/public/translations/secret-manager/Messages_fr_FR.json

@@ -38,8 +38,8 @@
   "error_update_settings": "Une erreur est survenue lors de la mise à jour des paramètres",
   "expiration_date": "Date d'expiration",
   "form_helper_cas_required_okms": "CAS est activé sur le domaine OKMS, la désactivation sur le secret ne sera pas prise en compte.",
-  "form_helper_deactivate_version_after": "Indiquez \"0s\" pour ne jamais expirer.",
-  "form_helper_max_versions": "Indiquez \"0\" pour utiliser la valeur par défaut.",
+  "form_helper_deactivate_version_after": "Indiquez \"0s\" pour désactiver l'expiration.",
+  "form_helper_max_versions": "Indiquez \"0\" pour utiliser la valeur par défaut ({{default}}).",
   "form_tooltip_deactivate_version_after": "Format : 30s, 5m, 2h, 7d, 7d1h30m10s",
   "last_update": "Dernière mise à jour",
   "maximum_number_of_versions": "Nombre maximum de versions",

packages/manager/apps/okms/src/modules/secret-manager/components/form/SecretMaxVersionsFormField.component.tsx

@@ -16,10 +16,17 @@ type FormFieldInput = {
   maxVersions: number;
 };
 
+type SecretMaxVersionsFormFieldProps<
+  T extends FormFieldInput
+> = UseControllerProps<T> & {
+  defaultMaxVersions: number;
+};
+
 export const SecretMaxVersionsFormField = <T extends FormFieldInput>({
   name,
   control,
-}: UseControllerProps<T>) => {
+  defaultMaxVersions,
+}: SecretMaxVersionsFormFieldProps<T>) => {
   const { t } = useTranslation('secret-manager');
   return (
     <Controller
@@ -42,7 +49,7 @@ export const SecretMaxVersionsFormField = <T extends FormFieldInput>({
             className="justify-start"
           />
           <OdsText slot="helper" preset="caption">
-            {t('form_helper_max_versions')}
+            {t('form_helper_max_versions', { default: defaultMaxVersions })}
           </OdsText>
         </OdsFormField>
       )}

packages/manager/apps/okms/src/modules/secret-manager/hooks/useSecretSmartConfig.spec.ts

@@ -91,6 +91,7 @@ const mockSecretSmartConfig: SecretSmartConfig = {
     origin: 'DOMAIN',
   },
   isCasRequiredSetOnOkms: true,
+  maxVersionsDefault: 10,
 };
 
 describe('useSecretSmartConfig', () => {

packages/manager/apps/okms/src/modules/secret-manager/pages/drawers/editMetadataDrawer/EditMetadataDrawerForm.component.spec.tsx

@@ -41,6 +41,7 @@ const mockSecretConfig: SecretSmartConfig = {
     origin: 'SECRET',
   },
   isCasRequiredSetOnOkms: true,
+  maxVersionsDefault: 10,
 };
 
 const mockOnDismiss = vi.fn();

packages/manager/apps/okms/src/modules/secret-manager/pages/drawers/editMetadataDrawer/EditMetadataDrawerForm.component.tsx

@@ -95,7 +95,11 @@ export const EditMetadataDrawerForm = ({
             name="deactivateVersionAfter"
             control={control}
           />
-          <SecretMaxVersionsFormField name="maxVersions" control={control} />
+          <SecretMaxVersionsFormField
+            name="maxVersions"
+            control={control}
+            defaultMaxVersions={secretConfig.maxVersionsDefault}
+          />
           <SecretCasRequiredFormField
             name="casRequired"
             control={control}

packages/manager/apps/okms/src/modules/secret-manager/pages/secret/generalInformation/SettingsTile.component.spec.tsx

@@ -45,6 +45,7 @@ const mockSecretSmartConfig: SecretSmartConfig = {
     origin: 'DOMAIN',
   },
   isCasRequiredSetOnOkms: true,
+  maxVersionsDefault: 10,
 };
 
 let i18nValue: i18n;

packages/manager/apps/okms/src/modules/secret-manager/utils/secretSmartConfig.spec.ts

@@ -37,7 +37,11 @@ describe('getSecretSmartConfig', () => {
     expectedValue: string | number | boolean;
     expectedOrigin: 'SECRET' | 'DOMAIN' | 'DEFAULT';
     expectedIsCasRequiredSetOnOkms: boolean;
-    testedProperty: Exclude<keyof SecretSmartConfig, 'isCasRequiredSetOnOkms'>;
+    expectedMaxVersionsDefault?: number;
+    testedProperty: Exclude<
+      keyof SecretSmartConfig,
+      'isCasRequiredSetOnOkms' | 'maxVersionsDefault'
+    >;
   };
 
   const runTests = (testCases: TestCase[]) => {
@@ -49,6 +53,7 @@ describe('getSecretSmartConfig', () => {
         expectedValue,
         expectedOrigin,
         expectedIsCasRequiredSetOnOkms,
+        expectedMaxVersionsDefault,
         testedProperty,
       }) => {
         const secret = createMockSecret(secretOverrides);
@@ -65,11 +70,14 @@ describe('getSecretSmartConfig', () => {
         expect(result.isCasRequiredSetOnOkms).toBe(
           expectedIsCasRequiredSetOnOkms,
         );
+        if (expectedMaxVersionsDefault) {
+          expect(result.maxVersionsDefault).toBe(expectedMaxVersionsDefault);
+        }
       },
     );
   };
 
-  describe('When secret and domain config is not set', () => {
+  describe('When secret and domain config are both not set', () => {
     const testCases: TestCase[] = [
       {
         description: 'uses default maxVersion',
@@ -78,6 +86,7 @@ describe('getSecretSmartConfig', () => {
         expectedValue: 10,
         expectedOrigin: 'DEFAULT',
         expectedIsCasRequiredSetOnOkms: false,
+        expectedMaxVersionsDefault: 10,
         testedProperty: 'maxVersions',
       },
       {

packages/manager/apps/okms/src/modules/secret-manager/utils/secretSmartConfig.ts

@@ -20,6 +20,7 @@ export type SecretSmartConfig = {
   deactivateVersionAfter: SecretSmartConfigValue<string>;
   maxVersions: SecretSmartConfigValue<number>;
   isCasRequiredSetOnOkms: boolean;
+  maxVersionsDefault: number;
 };
 
 /**
@@ -91,5 +92,6 @@ export const buildSecretSmartConfig = (
     ),
     isCasRequiredSetOnOkms:
       secretConfigOkms.casRequired !== NOT_SET_VALUE_CAS_REQUIRED,
+    maxVersionsDefault: secretConfigReference.maxVersions,
   };
 };