Skip to content

Commit 2ca8694

Browse files
helabenkhalfallahhelabenkhalfallah
authored
feat(muk): static quality improvement
1 parent ba111fd commit 2ca8694

File tree

469 files changed

+8128
-5576
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

469 files changed

+8128
-5576
lines changed

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,4 +135,4 @@
135135
"node": "^22",
136136
"yarn": ">=1.21.1"
137137
}
138-
}
138+
}

‎packages/manager-tools/manager-cli/static-analysis-migrate/steps/ts-config/addTSStaticKitConfig.mjs‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ if (!appName || appName.startsWith('--')) {
1717

1818
const appPath = path.resolve(applicationsBasePath, appName);
1919
const tsconfigPath = path.join(appPath, 'tsconfig.json');
20-
const tsconfigStrictPath = path.join(appPath, 'tsconfig.strict.json');
20+
const tsconfigStrictPath = path.join(appPath, 'tsconfig.json');
2121

2222
const basePriorAttributes = new Set([
2323
'strict',
@@ -60,7 +60,7 @@ const backupTSConfigFiles = async (appPath) => {
6060
if (err.code !== 'ENOENT') throw err;
6161
}
6262
};
63-
await Promise.all(['tsconfig.json', 'tsconfig.strict.json'].map(backup));
63+
await Promise.all(['tsconfig.json', 'tsconfig.json'].map(backup));
6464
};
6565

6666
/**
@@ -78,7 +78,7 @@ const removeTSConfigBackups = async (appPath) => {
7878
if (err.code !== 'ENOENT') throw err;
7979
}
8080
};
81-
await Promise.all(['tsconfig.json', 'tsconfig.strict.json'].map(remove));
81+
await Promise.all(['tsconfig.json', 'tsconfig.json'].map(remove));
8282
};
8383

8484
/**
@@ -184,7 +184,7 @@ const addTSStaticKitConfig = async () => {
184184
logBlock('Static-kit merged base', staticKitBase);
185185
logBlock('Computed delta', looseDelta);
186186
logBlock('Final tsconfig.json', looseFinal);
187-
logBlock('Final tsconfig.strict.json', strictFinal);
187+
logBlock('Final tsconfig.json', strictFinal);
188188
logDiff('tsconfig.json diff', appLoose, looseFinal);
189189
console.log('\n🧪 [dry-run] No changes written.');
190190
return;
@@ -194,7 +194,7 @@ const addTSStaticKitConfig = async () => {
194194
pkg.devDependencies['@ovh-ux/manager-static-analysis-kit'] = '*';
195195
pkg.scripts ||= {};
196196
if (!pkg.scripts['build:strict']) {
197-
pkg.scripts['build:strict'] = 'tsc --project tsconfig.strict.json && vite build';
197+
pkg.scripts['build:strict'] = 'tsc --project tsconfig.json && vite build';
198198
}
199199

200200
writePackageJson(appPath, pkg);

‎packages/manager-tools/manager-generator/template/vitest.config.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ export default mergeConfig(
2323
'**/QueryClient.ts',
2424
'**/*.type.ts',
2525
'**/404.page.tsx',
26-
'**/Test.utils.tsx',
26+
'**/Mock.utils.tsx',
2727
],
2828
},
2929
},

‎packages/manager-tools/manager-static-analysis-kit/README.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,13 +101,13 @@ yarn manager-types-coverage --package @ovh-ux/manager-container-app
101101
### Analyze specific libraries (by `package.json` name)
102102

103103
```bash
104-
yarn manager-types-coverage --libraries @ovh-ux/manager-wiki,@ovh-ux/manager-react-components
104+
yarn manager-types-coverage --libraries @ovh-ux/manager-wiki,@ovh-ux/muk
105105
```
106106

107107
or single library:
108108

109109
```bash
110-
yarn manager-types-coverage --library @ovh-ux/manager-react-components
110+
yarn manager-types-coverage --library @ovh-ux/muk
111111
```
112112

113113
> In this mode:

‎packages/manager-tools/manager-static-analysis-kit/bin/cli-path-config.js‎

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,13 +58,14 @@ export const combinedReportOutputRootDir = path.resolve(
5858

5959
export const staticDiscoveredLibraries = [
6060
{
61-
fullPath: 'packages/manager-react-components',
62-
shortPath: 'manager-react-components',
63-
packageName: '@ovh-ux/manager-react-components',
64-
},
65-
{
66-
fullPath: 'packages/manager-wiki',
67-
shortPath: 'manager-wiki',
68-
packageName: '@ovh-ux/manager-wiki',
61+
fullPath: 'packages/manager-ui-kit',
62+
shortPath: 'manager-ui-kit',
63+
packageName: '@ovh-ux/muk',
6964
},
7065
];
66+
67+
export const typesSpecificIgnorePatterns = [
68+
/(^|\/)(__tests__|tests?|spec|fixtures|stubs|mocks)\//i,
69+
/\.(test|spec|stories?)\.(ts|tsx)$/i,
70+
/(^|\/)i18n(\.ts|\.tsx)?$/i,
71+
];

‎packages/manager-tools/manager-static-analysis-kit/bin/code-duplication-tests-cli.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ const cases = [
2222
expect: 0,
2323
},
2424
{
25-
name: 'Single library static path by folder name (manager-react-components)',
26-
cmd: 'yarn manager-code-duplication --library manager-react-components',
25+
name: 'Single library static path by folder name (manager-ui-kit)',
26+
cmd: 'yarn manager-code-duplication --library manager-ui-kit',
2727
expect: 0,
2828
},
2929
{
30-
name: 'Single library static path by package name (manager-react-components)',
31-
cmd: 'yarn manager-code-duplication --library @ovh-ux/manager-react-components',
30+
name: 'Single library static path by package name (manager-ui-kit)',
31+
cmd: 'yarn manager-code-duplication --library @ovh-ux/muk',
3232
expect: 0,
3333
},
3434
{
@@ -42,13 +42,13 @@ const cases = [
4242
expect: 0,
4343
},
4444
{
45-
name: 'Multiple libraries by folder names (manager-wiki,manager-react-components,shell-client,logs-to-customer)',
46-
cmd: 'yarn manager-code-duplication --libraries manager-wiki,manager-react-components,shell-client,logs-to-customer',
45+
name: 'Multiple libraries by folder names (manager-wiki,manager-ui-kit,shell-client,logs-to-customer)',
46+
cmd: 'yarn manager-code-duplication --libraries manager-wiki,manager-ui-kit,shell-client,logs-to-customer',
4747
expect: 0,
4848
},
4949
{
50-
name: 'Multiple libraries by package names (manager-wiki,manager-react-components,shell-client,logs-to-customer)',
51-
cmd: 'yarn manager-code-duplication --libraries @ovh-ux/manager-wiki,@ovh-ux/manager-react-components,@ovh-ux/manager-react-shell-client,@ovh-ux/logs-to-customer',
50+
name: 'Multiple libraries by package names (manager-wiki,manager-ui-kit,shell-client,logs-to-customer)',
51+
cmd: 'yarn manager-code-duplication --libraries @ovh-ux/manager-wiki,@ovh-ux/muk,@ovh-ux/manager-react-shell-client,@ovh-ux/logs-to-customer',
5252
expect: 0,
5353
},
5454
{
@@ -58,7 +58,7 @@ const cases = [
5858
},
5959
{
6060
name: 'Mixed valid+invalid packages',
61-
cmd: 'yarn manager-code-duplication --packages @ovh-ux/manager-wiki,manager-react-components,@ovh-ux/manager-ghost-app',
61+
cmd: 'yarn manager-code-duplication --packages @ovh-ux/manager-wiki,manager-ui-kit,@ovh-ux/manager-ghost-app',
6262
expect: 0,
6363
},
6464
{

‎packages/manager-tools/manager-static-analysis-kit/bin/perf-budgets-tests-cli.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ const cases = [
2222
expect: 0,
2323
},
2424
{
25-
name: 'Single library static path by folder name (manager-react-components)',
26-
cmd: 'yarn manager-perf-budgets --library manager-react-components',
25+
name: 'Single library static path by folder name (manager-ui-kit)',
26+
cmd: 'yarn manager-perf-budgets --library manager-ui-kit',
2727
expect: 0,
2828
},
2929
{
30-
name: 'Single library static path by package name (manager-react-components)',
31-
cmd: 'yarn manager-perf-budgets --library @ovh-ux/manager-react-components',
30+
name: 'Single library static path by package name (manager-ui-kit)',
31+
cmd: 'yarn manager-perf-budgets --library @ovh-ux/muk',
3232
expect: 0,
3333
},
3434
{
@@ -42,13 +42,13 @@ const cases = [
4242
expect: 0,
4343
},
4444
{
45-
name: 'Multiple libraries by folder names (manager-wiki,manager-react-components,shell-client,logs-to-customer)',
46-
cmd: 'yarn manager-perf-budgets --libraries manager-wiki,manager-react-components,shell-client,logs-to-customer',
45+
name: 'Multiple libraries by folder names (manager-wiki,manager-ui-kit,shell-client,logs-to-customer)',
46+
cmd: 'yarn manager-perf-budgets --libraries manager-wiki,manager-ui-kit,shell-client,logs-to-customer',
4747
expect: 0,
4848
},
4949
{
50-
name: 'Multiple libraries by package names (manager-wiki,manager-react-components,shell-client,logs-to-customer)',
51-
cmd: 'yarn manager-perf-budgets --libraries @ovh-ux/manager-wiki,@ovh-ux/manager-react-components,@ovh-ux/manager-react-shell-client,@ovh-ux/logs-to-customer',
50+
name: 'Multiple libraries by package names (manager-wiki,manager-ui-kit,shell-client,logs-to-customer)',
51+
cmd: 'yarn manager-perf-budgets --libraries @ovh-ux/manager-wiki,@ovh-ux/muk,@ovh-ux/manager-react-shell-client,@ovh-ux/logs-to-customer',
5252
expect: 0,
5353
},
5454
{
@@ -58,7 +58,7 @@ const cases = [
5858
},
5959
{
6060
name: 'Mixed valid+invalid packages',
61-
cmd: 'yarn manager-perf-budgets --packages @ovh-ux/manager-wiki,manager-react-components,@ovh-ux/manager-ghost-app',
61+
cmd: 'yarn manager-perf-budgets --packages @ovh-ux/manager-wiki,manager-ui-kit,@ovh-ux/manager-ghost-app',
6262
expect: 0,
6363
},
6464
{

‎packages/manager-tools/manager-static-analysis-kit/bin/tests-coverage-cli-tests.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ const cases = [
2222
expect: 0,
2323
},
2424
{
25-
name: 'Single library static path by folder name (manager-react-components)',
26-
cmd: 'yarn manager-tests-coverage --library manager-react-components',
25+
name: 'Single library static path by folder name (manager-ui-kit)',
26+
cmd: 'yarn manager-tests-coverage --library manager-ui-kit',
2727
expect: 0,
2828
},
2929
{
30-
name: 'Single library static path by package name (manager-react-components)',
31-
cmd: 'yarn manager-tests-coverage --library @ovh-ux/manager-react-components',
30+
name: 'Single library static path by package name (manager-ui-kit)',
31+
cmd: 'yarn manager-tests-coverage --library @ovh-ux/muk',
3232
expect: 0,
3333
},
3434
{
@@ -42,13 +42,13 @@ const cases = [
4242
expect: 0,
4343
},
4444
{
45-
name: 'Multiple libraries by folder names (manager-wiki,manager-react-components,shell-client,logs-to-customer)',
46-
cmd: 'yarn manager-tests-coverage --libraries manager-wiki,manager-react-components,shell-client,logs-to-customer',
45+
name: 'Multiple libraries by folder names (manager-wiki,manager-ui-kit,shell-client,logs-to-customer)',
46+
cmd: 'yarn manager-tests-coverage --libraries manager-wiki,manager-ui-kit,shell-client,logs-to-customer',
4747
expect: 0,
4848
},
4949
{
50-
name: 'Multiple libraries by package names (manager-wiki,manager-react-components,shell-client,logs-to-customer)',
51-
cmd: 'yarn manager-tests-coverage --libraries @ovh-ux/manager-wiki,@ovh-ux/manager-react-components,@ovh-ux/manager-react-shell-client,@ovh-ux/logs-to-customer',
50+
name: 'Multiple libraries by package names (manager-wiki,manager-ui-kit,shell-client,logs-to-customer)',
51+
cmd: 'yarn manager-tests-coverage --libraries @ovh-ux/manager-wiki,@ovh-ux/muk,@ovh-ux/manager-react-shell-client,@ovh-ux/logs-to-customer',
5252
expect: 0,
5353
},
5454
{
@@ -58,7 +58,7 @@ const cases = [
5858
},
5959
{
6060
name: 'Mixed valid+invalid packages',
61-
cmd: 'yarn manager-tests-coverage --packages @ovh-ux/manager-wiki,manager-react-components,@ovh-ux/manager-ghost-app',
61+
cmd: 'yarn manager-tests-coverage --packages @ovh-ux/manager-wiki,manager-ui-kit,@ovh-ux/manager-ghost-app',
6262
expect: 0,
6363
},
6464
{

‎packages/manager-tools/manager-static-analysis-kit/bin/types-coverage-cli.js‎

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
typesCoverageCombinedJsonReportName,
1515
typesCoverageOutputRootDir,
1616
typesCoverageReportsRootDirName,
17+
typesSpecificIgnorePatterns,
1718
} from './cli-path-config.js';
1819
import { buildTypesCoverageArgs, parseCliTargets } from './utils/args-parse-utils.js';
1920
import { logError, logInfo, logWarn } from './utils/log-utils.js';
@@ -102,12 +103,18 @@ export function countLooseTypes(appDir) {
102103
visit(source);
103104
}
104105

106+
function shouldIgnore(filePath) {
107+
return typesSpecificIgnorePatterns.some((re) => re.test(filePath));
108+
}
109+
105110
function walk(dir) {
106111
for (const entry of fs.readdirSync(dir, { withFileTypes: true })) {
107112
const fullPath = path.join(dir, entry.name);
108113
if (entry.isDirectory()) {
114+
if (shouldIgnore(fullPath)) continue;
109115
walk(fullPath);
110116
} else if (/\.(ts|tsx)$/.test(entry.name)) {
117+
if (shouldIgnore(fullPath)) continue;
111118
analyzeFile(fullPath);
112119
}
113120
}

‎packages/manager-tools/manager-static-analysis-kit/bin/types-coverage-tests-cli.js‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -22,13 +22,13 @@ const cases = [
2222
expect: 0,
2323
},
2424
{
25-
name: 'Single library static path by folder name (manager-react-components)',
26-
cmd: 'yarn manager-types-coverage --library manager-react-components',
25+
name: 'Single library static path by folder name (manager-ui-kit)',
26+
cmd: 'yarn manager-types-coverage --library manager-ui-kit',
2727
expect: 0,
2828
},
2929
{
30-
name: 'Single library static path by package name (manager-react-components)',
31-
cmd: 'yarn manager-types-coverage --library @ovh-ux/manager-react-components',
30+
name: 'Single library static path by package name (manager-ui-kit)',
31+
cmd: 'yarn manager-types-coverage --library @ovh-ux/muk',
3232
expect: 0,
3333
},
3434
{
@@ -42,13 +42,13 @@ const cases = [
4242
expect: 0,
4343
},
4444
{
45-
name: 'Multiple libraries by folder names (manager-wiki,manager-react-components,shell-client,logs-to-customer)',
46-
cmd: 'yarn manager-types-coverage --libraries manager-wiki,manager-react-components,shell-client,logs-to-customer',
45+
name: 'Multiple libraries by folder names (manager-wiki,manager-ui-kit,shell-client,logs-to-customer)',
46+
cmd: 'yarn manager-types-coverage --libraries manager-wiki,manager-ui-kit,shell-client,logs-to-customer',
4747
expect: 0,
4848
},
4949
{
50-
name: 'Multiple libraries by package names (manager-wiki,manager-react-components,shell-client,logs-to-customer)',
51-
cmd: 'yarn manager-types-coverage --libraries @ovh-ux/manager-wiki,@ovh-ux/manager-react-components,@ovh-ux/manager-react-shell-client,@ovh-ux/logs-to-customer',
50+
name: 'Multiple libraries by package names (manager-wiki,manager-ui-kit,shell-client,logs-to-customer)',
51+
cmd: 'yarn manager-types-coverage --libraries @ovh-ux/manager-wiki,@ovh-ux/muk,@ovh-ux/manager-react-shell-client,@ovh-ux/logs-to-customer',
5252
expect: 0,
5353
},
5454
{
@@ -58,7 +58,7 @@ const cases = [
5858
},
5959
{
6060
name: 'Mixed valid+invalid packages',
61-
cmd: 'yarn manager-types-coverage --packages @ovh-ux/manager-wiki,manager-react-components,@ovh-ux/manager-ghost-app',
61+
cmd: 'yarn manager-types-coverage --packages @ovh-ux/manager-wiki,manager-ui-kit,@ovh-ux/manager-ghost-app',
6262
expect: 0,
6363
},
6464
{

0 commit comments

Comments
 (0)