fix(okms): kmip public ca button downloads the wrong file

ref: #MANAGER-18832

Signed-off-by: Mathieu Mousnier <[email protected]>

Author: mathieumousnier

packages/manager/apps/okms/src/components/dashboard/downloadKmsPublicCaLink/DownloadKmsPublicCaLink.spec.tsx

@@ -77,18 +77,30 @@ describe('DownloadKmsPublicCaLink component tests suite', () => {
   const buttons: {
     type: CertificateType;
     label: string;
+    expectedCa: 'publicCA' | 'publicRsaCA';
+    expectedFilename: string;
+    expectedCertificate: string;
   }[] = [
     {
       type: 'publicCaRest',
       label: 'key_management_service_dashboard_button_label_download_ca',
+      expectedCa: 'publicCA',
+      expectedFilename: 'okms_test-region_public_ca.pem',
+      expectedCertificate: mockCertificates.publicCA,
     },
     {
       type: 'publicCaKmip',
       label: 'key_management_service_dashboard_button_label_download_ca',
+      expectedCa: 'publicCA',
+      expectedFilename: 'okms_test-region_public_ca.pem',
+      expectedCertificate: mockCertificates.publicCA,
     },
     {
       type: 'publicCaRsaKmip',
       label: 'key_management_service_dashboard_button_label_download_rsa_ca',
+      expectedCa: 'publicRsaCA',
+      expectedFilename: 'okms_test-region_public_rsa_ca.pem',
+      expectedCertificate: mockCertificates.publicRsaCA,
     },
   ];
 
@@ -103,26 +115,29 @@ describe('DownloadKmsPublicCaLink component tests suite', () => {
     },
   );
 
-  test('should download publicCa certificate when clicked', async () => {
-    const { downloadLink } = await renderComponentAndGetLink({
-      type: 'publicCaRest',
-      label: 'key_management_service_dashboard_button_label_download_ca',
-    });
+  test.each(buttons)(
+    'should download $expectedCa certificate when clicked on $type button',
+    async ({ type, label, expectedFilename, expectedCertificate }) => {
+      const { downloadLink } = await renderComponentAndGetLink({
+        type,
+        label,
+      });
 
-    const user = userEvent.setup();
-    await waitFor(() => user.click(downloadLink));
+      const user = userEvent.setup();
+      await waitFor(() => user.click(downloadLink));
 
-    await waitFor(() => {
-      expect(api.getOkmsPublicCa).toHaveBeenCalledWith(mockOkms.id);
-    });
+      await waitFor(() => {
+        expect(api.getOkmsPublicCa).toHaveBeenCalledWith(mockOkms.id);
+      });
 
-    await waitFor(() => {
-      expect(initiateTextFileDownload).toHaveBeenCalledWith({
-        text: mockCertificates.publicCA,
-        filename: 'okms_test-region_public_ca.pem',
+      await waitFor(() => {
+        expect(initiateTextFileDownload).toHaveBeenCalledWith({
+          text: expectedCertificate,
+          filename: expectedFilename,
+        });
       });
-    });
-  });
+    },
+  );
 
   test('should download publicRsaCa certificate when clicked', async () => {
     const { downloadLink } = await renderComponentAndGetLink({

packages/manager/apps/okms/src/components/dashboard/downloadKmsPublicCaLink/DownloadKmsPublicCaLink.tsx

@@ -14,7 +14,7 @@ import {
   PUBLIC_CA_FILENAME,
   PUBLIC_RSA_CA_FILENAME,
 } from './downloadKmsPublicCaLink.constants';
-import { OKMS } from '@/types/okms.type';
+import { OKMS, OkmsPublicCa } from '@/types/okms.type';
 
 export type CertificateType =
   | 'publicCaRest'
@@ -24,6 +24,7 @@ export type CertificateType =
 type ButtonResource = {
   label: string;
   filename: string;
+  certificateType: keyof OkmsPublicCa;
   tracking: string;
 };
 
@@ -45,16 +46,19 @@ export const DownloadKmsPublicCaLink = ({
     publicCaRest: {
       label: t('key_management_service_dashboard_button_label_download_ca'),
       filename: PUBLIC_CA_FILENAME,
+      certificateType: 'publicCA',
       tracking: 'download_rest-api-endpoint-ca',
     },
     publicCaKmip: {
       label: t('key_management_service_dashboard_button_label_download_ca'),
-      filename: PUBLIC_RSA_CA_FILENAME,
+      filename: PUBLIC_CA_FILENAME,
+      certificateType: 'publicCA',
       tracking: 'download_kmip-endpoint-ca',
     },
     publicCaRsaKmip: {
       label: t('key_management_service_dashboard_button_label_download_rsa_ca'),
       filename: PUBLIC_RSA_CA_FILENAME,
+      certificateType: 'publicRsaCA',
       tracking: 'download_kmip-endpoint-ca-rsa',
     },
   };
@@ -68,14 +72,8 @@ export const DownloadKmsPublicCaLink = ({
       setLoading(true);
       const certificates = await getOkmsPublicCa(okms.id);
 
-      const content: Record<CertificateType, string> = {
-        publicCaRest: certificates.publicCA,
-        publicCaKmip: certificates.publicRsaCA,
-        publicCaRsaKmip: certificates.publicRsaCA,
-      };
-
       initiateTextFileDownload({
-        text: content[type],
+        text: certificates[resources[type].certificateType],
         filename: resources[type].filename.replace('{region}', okms.region),
       });