fix(okms): fix kms tests

ref: #MANAGER-19793

Signed-off-by: Romain Jamet <[email protected]>

Author: Romain Jamet

packages/manager/apps/okms/src/common/components/okmsDatagrid/OkmsDatagrid.component.spec.tsx

@@ -95,7 +95,6 @@ describe('Okms Datagrid tests suite', () => {
     expect(await screen.findAllByText(columns.servicekeyCount)).toHaveLength(1);
     expect(await screen.findAllByText(columns.region)).toHaveLength(1);
     expect(await screen.findAllByText(columns.status)).toHaveLength(1);
-    expect(screen.getByTestId('header-action')).toBeVisible();
 
     // hidden columns
     expect(screen.queryByText(columns.secretCount)).not.toBeInTheDocument();
@@ -114,6 +113,5 @@ describe('Okms Datagrid tests suite', () => {
     expect(screen.queryByText(columns.kmipCount)).not.toBeInTheDocument();
     expect(screen.queryByText(columns.servicekeyCount)).not.toBeInTheDocument();
     expect(screen.queryByText(columns.region)).not.toBeInTheDocument();
-    expect(screen.queryByTestId('header-action')).not.toBeInTheDocument();
   });
 });

packages/manager/apps/okms/src/components/layout-helpers/Dashboard/KmsTabs.tsx

@@ -67,6 +67,7 @@ const KmsTabs: React.FC<KmsTabsProps> = ({ tabs }) => {
     >
       {tabs.map((tab: KmsTabProps, index) => (
         <OdsTab
+          data-testid={tab.url}
           key={`ods-tab-bar-item-${tab.url}`}
           id={tab.url}
           isSelected={index === activeTabIndex}

packages/manager/apps/okms/src/mocks/services/services.mock.ts

@@ -1,4 +1,5 @@
 import { CurrencyCode, ServiceDetails } from '@ovh-ux/manager-react-components';
+import { okmsMock } from '../kms/okms.mock';
 
 export const kmsServicesMock: ServiceDetails = {
   route: {
@@ -68,7 +69,7 @@ export const kmsServicesMock: ServiceDetails = {
     engagementRequest: { pricingMode: '', requestDate: '' },
   },
   resource: {
-    displayName: 'testkms123k',
+    displayName: okmsMock[0].iam.displayName,
     name: '7f3a82ac-a8d8-4c2a-ab0c-f6e86ddf6a7c',
     state: 'active',
     product: {

packages/manager/apps/okms/src/modules/secret-manager/components/regionSelector/RegionSelector.component.spec.tsx

@@ -10,7 +10,7 @@ import {
   getOdsButtonByLabel,
   getOdsButtonByIcon,
 } from '@/utils/tests/uiTestHelpers';
-import { initTestI18n } from '@/utils/tests/init.i18n';
+import { initTestI18n, labels } from '@/utils/tests/init.i18n';
 import {
   GeographyGroup,
   RegionOption,
@@ -161,7 +161,7 @@ describe('RegionSelector Component', () => {
       const { container } = await renderRegionSelector();
 
       // Then
-      expect(screen.getByText('region')).toBeInTheDocument();
+      expect(screen.getByText(labels.common.region.region)).toBeInTheDocument();
       await getOdsButtonByLabel({ container, label: mockCurrentRegion.label });
     });
 

packages/manager/apps/okms/src/pages/dashboard/KmsDashboard.page.spec.tsx

@@ -13,7 +13,17 @@ import { KMS_FEATURES } from '@/utils/feature-availability/feature-availability.
 import { SERVICE_KEYS_LABEL } from '@/constants';
 import { KMS_ROUTES_URLS } from '@/routes/routes.constants';
 
-const mockPageUrl = KMS_ROUTES_URLS.kmsDashboard(okmsMock[0].id);
+const mockedOkms = okmsMock[0];
+const mockPageUrl = KMS_ROUTES_URLS.kmsDashboard(mockedOkms.id);
+
+const generalInformationTabTestId = KMS_ROUTES_URLS.kmsDashboard(mockedOkms.id);
+const serviceKeyListTabTestId = KMS_ROUTES_URLS.serviceKeyListing(
+  mockedOkms.id,
+);
+const credentialListTabTestId = KMS_ROUTES_URLS.credentialListing(
+  mockedOkms.id,
+);
+const logTabTestId = KMS_ROUTES_URLS.kmsLogs(mockedOkms.id);
 
 describe('KMS dashboard test suite', () => {
   it('should display an error if the API is KO', async () => {
@@ -34,14 +44,10 @@ describe('KMS dashboard test suite', () => {
 
     await waitFor(
       () => {
-        expect(
-          screen.getAllByText(labels.dashboard.general_informations)[0],
-        ).toBeVisible();
-        expect(screen.getByText(SERVICE_KEYS_LABEL)).toBeVisible();
-        expect(
-          screen.getByText(labels.dashboard.access_certificates),
-        ).toBeVisible();
-        expect(screen.getByText(labels.dashboard.logs)).toBeVisible();
+        expect(screen.getByTestId(generalInformationTabTestId)).toBeVisible();
+        expect(screen.getByTestId(serviceKeyListTabTestId)).toBeVisible();
+        expect(screen.getByTestId(credentialListTabTestId)).toBeVisible();
+        expect(screen.getByTestId(logTabTestId)).toBeVisible();
       },
 
       WAIT_FOR_DEFAULT_OPTIONS,
@@ -71,11 +77,15 @@ describe('KMS dashboard test suite', () => {
     await renderTestApp(mockPageUrl);
 
     await waitFor(
-      () => expect(screen.getByText(SERVICE_KEYS_LABEL)).toBeEnabled(),
+      () => expect(screen.getByTestId(serviceKeyListTabTestId)).toBeEnabled(),
       WAIT_FOR_DEFAULT_OPTIONS,
     );
 
-    await waitFor(() => userEvent.click(screen.getByText(SERVICE_KEYS_LABEL)));
+    await waitFor(() =>
+      userEvent.click(
+        screen.getByTestId(KMS_ROUTES_URLS.serviceKeyListing(mockedOkms.id)),
+      ),
+    );
 
     await waitFor(
       () =>
@@ -92,10 +102,7 @@ describe('KMS dashboard test suite', () => {
     await renderTestApp(mockPageUrl);
 
     await waitFor(
-      () =>
-        expect(
-          screen.getByText(labels.dashboard.access_certificates),
-        ).toBeEnabled(),
+      () => expect(screen.getByTestId(credentialListTabTestId)).toBeEnabled(),
       WAIT_FOR_DEFAULT_OPTIONS,
     );
 
@@ -128,9 +135,7 @@ describe('KMS dashboard test suite', () => {
     await assertOdsModalVisibility({ container, isVisible: true });
 
     expect(
-      await screen.findByText(
-        labels.credentials.key_management_service_credential_dashboard_name,
-      ),
+      await screen.findByText(labels.common.actions.modify_name),
     ).toBeVisible();
   });
 });