Foliage color is wrong

[joe-mojo]

Even after fix for issue #973 (#974), foliage color is wrong because load_foliage_color in textures.y is not used.

The result (foliage color not consistent with texture oack) is a regression (clearly visible on an old map refreshed with newer overviewer).

Other unused functions that should be used (unknown impact) :
load_light_color
load_grass_color
load_water_color
load_water_color

[agrif]

load_foliage_color is called in the Base primitive source code, along with the water colors and grass colors. Light color is loaded inside the lighting primitive.

So the problem is probably that load_foliage_color is being called, but it's not finding anything.

[joe-mojo]

Sorry but I force log output for find_file that is called by load_image itself called by load_foliage_color, I have no log for foliage. I have log for all other textures. I added logging.info() calls inside load_foliage_color, but I have no trace (except all other call to logging.info() that are OK since I launched with -v.

So why no trace of load_foliage_color call ?

[CounterPillow]

It seems as if base_start never gets called at all. Odd.