Skip to content

/diff endpoint reports no diff in redorderd lists  #89

Open
@rosibaj

Description

@rosibaj

Description

When comparing two dictionaries with the /diff endpoint, if a list is reordered it reports an empty diff object for that field

Expected Behaviour

This should not be reported as a difference, as the data hasn't actually changed.

Actual Behaviour

image

Possible Fix

Steps to Reproduce

  1. Go to argo-qa environment and compare the two RC candiate dictionaryed 0.10 and 0.11
curl --location --request GET 'https://lectern.qa.argo.cancercollaboratory.org/diff?name=ICGC-ARGO%20Data%20Dictionary%20RC%200.10&left=0.10&right=0.11'
  1. Look at the "donor.menopause_status", diff object
  2. see the empty diff objcet:
 "diff": {}

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions