fix(lib/client): recursion in player.get and nullish operator

thelindat · thelindat · commit 01de45c84b21 · 2024-11-14T03:21:06.000+11:00
diff --git a/lib/client/player.ts b/lib/client/player.ts
@@ -51,8 +51,8 @@ class PlayerInterface {
     if (!this.charId) return;
 
     if (!(key in this)) {
+      this[key] = exports.ox_core.CallPlayer('get', key) ?? null;
       this.on(key, (data: unknown) => (this[key] = data));
-      this[key] = exports.ox_core.CallPlayer('get', key) || null;
     }
 
     return this[key];

Original file line number	Diff line number	Diff line change
`@@ -51,8 +51,8 @@ class PlayerInterface {`
`51`	`51`	`if (!this.charId) return;`
`52`	`52`
`53`	`53`	`if (!(key in this)) {`
	`54`	`+ this[key] = exports.ox_core.CallPlayer('get', key) ?? null;`
`54`	`55`	`this.on(key, (data: unknown) => (this[key] = data));`
`55`		`- this[key] = exports.ox_core.CallPlayer('get', key) \|\| null;`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`return this[key];`