Fix TypeError in getValueAttribute and add type validation

- Fixed trim() being called on array values (PHPStan error)
- Added type validation with exceptions for array, string, and regex types
- Throw UnexpectedValueException when decoded value doesn't match expected type

Author: ottosmops

src/Setting.php

@@ -110,6 +110,7 @@ public static function isEditable(string $key): bool
      *
      * @param  mixed $value
      * @return mixed
+     * @throws \UnexpectedValueException
      */
     public function getValueAttribute($value)
     {
@@ -120,7 +121,11 @@ public function getValueAttribute($value)
         switch ($this->type) {
             case 'arr':
             case 'array':
-                return json_decode($value, true);
+                $decoded = json_decode($value, true);
+                if (!is_array($decoded)) {
+                    throw new \UnexpectedValueException("Expected array for key '{$this->key}', got " . gettype($decoded));
+                }
+                return $decoded;
             case 'int':
             case 'integer':
                 return intval($value);
@@ -131,12 +136,22 @@ public function getValueAttribute($value)
                 }
                 return boolval($value);
             case 'regex':
+                if (!is_string($value)) {
+                    throw new \UnexpectedValueException("Expected string for regex key '{$this->key}', got " . gettype($value));
+                }
                 $value = str_replace('ç€π', '\\', $value);
                 $value = str_replace('@ƻ', '/', $value);
                 return trim($value, '"');
             case 'string':
-                $value = json_decode($value, true);
+                $decoded = json_decode($value, true);
+                if (!is_string($decoded) && $decoded !== null) {
+                    throw new \UnexpectedValueException("Expected string for key '{$this->key}', got " . gettype($decoded));
+                }
+                return is_string($decoded) ? trim($decoded, '"') : $decoded;
             default:
+                if (!is_string($value)) {
+                    throw new \UnexpectedValueException("Expected string for key '{$this->key}', got " . gettype($value));
+                }
                 return trim($value, '"');
         }
     }