AppImage crash on startup: UnboundLocalError ffmpeg_path in otsconfig.py

[burtvadr]

Operating System

Linux

Account Type

Premium

Service

Other

Bug Description

Describe the bug
OnTheSpot crashes immediately on startup when launched via the AppImage.
The application exits with a Python traceback before the GUI loads.

To Reproduce

1. Download OnTheSpot-x86_64.AppImage
2. Make it executable
3. Launch it from a terminal

Expected behavior
OnTheSpot should start normally, or show a clear error message if ffmpeg
is missing or cannot be detected.

Actual behavior
Immediate crash with an UnboundLocalError.

Traceback
(most recent call last):
File "", line 198, in _run_module_as_main
File "", line 88, in _run_code
File "/tmp/.mount_OnTheSEidAdc/opt/python3.12/lib/python3.12/site-packages/onthespot/gui.py", line 9, in
from .qt.mainui import MainWindow
File "/tmp/.mount_OnTheSEidAdc/opt/python3.12/lib/python3.12/site-packages/onthespot/qt/mainui.py", line 11, in
from ..accounts import get_account_token, FillAccountPool
File "/tmp/.mount_OnTheSEidAdc/opt/python3.12/lib/python3.12/site-packages/onthespot/accounts.py", line 3, in
from .api.apple_music import apple_music_login_user, apple_music_get_token
File "/tmp/.mount_OnTheSEidAdc/opt/python3.12/lib/python3.12/site-packages/onthespot/api/apple_music.py", line 12, in
from ..otsconfig import config
File "/tmp/.mount_OnTheSEidAdc/opt/python3.12/lib/python3.12/site-packages/onthespot/otsconfig.py", line 399, in
config = Config()
File "/tmp/.mount_OnTheSEidAdc/opt/python3.12/lib/python3.12/site-packages/onthespot/otsconfig.py", line 266, in init
if not ffmpeg_path:
^^^^^^^^^^^
UnboundLocalError: cannot access local variable 'ffmpeg_path' where it is not associated with a value

**Environment**
- OS: Fedora Linux
- AppImage: OnTheSpot-x86_64.AppImage
- Python: bundled Python 3.12 (AppImage)

**Additional context**
It appears `ffmpeg_path` is referenced before being assigned when ffmpeg
is not found, causing an UnboundLocalError instead of a handled failure.

[liberatorcnx]

You would need to download the source then edit otsconfig.py and rebuild to create a new AppImage file. If you do, try the following:

The issue is that ffmpeg_path is only assigned inside the loop when a valid path is found. If none of the candidates are valid, the variable never gets created, causing the UnboundLocalError when you try to check if not ffmpeg_path. See if this fixes it - it did for me:

Find this section in otsconfig.py and add a line as shown below:

# Set FFMPEG Path
self.app_root = os.path.dirname(os.path.realpath(file))
ffmpeg_path_candidates = [
os.environ.get("FFMPEG_PATH", ""), # ENV
"/usr/bin/ffmpeg", # UNIX
"/opt/homebrew/bin/ffmpeg", # MACOS ARM
"/usr/local/bin/ffmpeg", # MACOS INTEL
os.path.join(
self.app_root, "bin", "ffmpeg", "ffmpeg" + self.ext_
), # BUNDLED
]

**ADD THIS LINE >ffmpeg_path = None # Initialize before the loop

for path in ffmpeg_path_candidates:

[moddroid94]

Please download the latest beta release, it fixes most of the problems in previous version:

https://github.com/justin025/onthespot/releases/tag/1.8.0beta

reopen if it persist.