Merge pull request #3 from otectus/claude/map-archer-codebase-XxiUl

Enhance security, logging, and testing across modules

Author: otectus

.editorconfig

@@ -0,0 +1,28 @@
+# EditorConfig for Archer Compatibility Suite
+# https://editorconfig.org
+
+root = true
+
+[*]
+end_of_line = lf
+insert_final_newline = true
+charset = utf-8
+trim_trailing_whitespace = true
+
+[*.sh]
+indent_style = space
+indent_size = 4
+
+[*.py]
+indent_style = space
+indent_size = 4
+
+[*.{yml,yaml}]
+indent_style = space
+indent_size = 2
+
+[*.md]
+trim_trailing_whitespace = false
+
+[Makefile]
+indent_style = tab

.shellcheckrc

@@ -0,0 +1,18 @@
+# ShellCheck configuration for Archer Compatibility Suite
+# https://www.shellcheck.net/wiki/
+
+# We use Bash-specific features throughout (set via #!/usr/bin/env bash)
+shell=bash
+
+# Allow sourcing from paths relative to the script
+source-path=SCRIPTDIR
+source-path=SCRIPTDIR/lib
+
+# SC2034: Variable appears unused — module scripts set variables consumed by install.sh
+disable=SC2034
+
+# SC1090: Can't follow non-constant source — modules are sourced dynamically
+disable=SC1090
+
+# SC1091: Not following sourced file — shellcheck can't resolve dynamic paths
+disable=SC1091

README.md

@@ -163,6 +163,8 @@ The installer will:
 | `--verify` | Check status of previously installed modules |
 | `--no-confirm` | Skip all confirmation prompts |
 | `--dry-run` | Show what would be done without making changes |
+| `--verbose` | Enable debug output for troubleshooting |
+| `--log FILE` | Write all output to FILE (in addition to console) |
 | `--help`, `-h` | Show help message |
 | `--version`, `-v` | Show installer version |
 

gui/archer/application.py

@@ -6,7 +6,7 @@
 import gi
 gi.require_version("Gtk", "4.0")
 gi.require_version("Adw", "1")
-from gi.repository import Adw, Gio, GLib
+from gi.repository import Adw, Gio
 
 from archer.window import ArcherWindow
 

gui/archer/pages/battery.py

@@ -5,7 +5,7 @@
 import gi
 gi.require_version("Gtk", "4.0")
 gi.require_version("Adw", "1")
-from gi.repository import Gtk, Adw, GLib
+from gi.repository import Gtk, Adw
 
 import threading
 
@@ -27,8 +27,9 @@ def _build_ui(self):
         self.status_group = Adw.PreferencesGroup(title="Battery Status")
 
         self.bat_percentage_row = Adw.ActionRow(title="Charge Level", subtitle="--")
-        self.bat_percentage_bar = Gtk.LevelBar(min_value=0, max_value=100, hexpand=True,
-                                                valign=Gtk.Align.CENTER)
+        self.bat_percentage_bar = Gtk.LevelBar(
+            min_value=0, max_value=100, hexpand=True,
+            valign=Gtk.Align.CENTER)
         self.bat_percentage_bar.set_size_request(200, -1)
         self.bat_percentage_row.add_suffix(self.bat_percentage_bar)
         self.status_group.add(self.bat_percentage_row)
@@ -67,8 +68,9 @@ def _build_ui(self):
         self.calibration_group.add(self.calibration_status_row)
 
         # Calibration buttons
-        cal_button_box = Gtk.Box(orientation=Gtk.Orientation.HORIZONTAL, spacing=12,
-                                  halign=Gtk.Align.CENTER, margin_top=12)
+        cal_button_box = Gtk.Box(
+            orientation=Gtk.Orientation.HORIZONTAL, spacing=12,
+            halign=Gtk.Align.CENTER, margin_top=12)
 
         self.start_cal_button = Gtk.Button(label="Start Calibration")
         self.start_cal_button.add_css_class("suggested-action")
@@ -124,8 +126,9 @@ def _build_ui(self):
             orientation=Gtk.Orientation.VERTICAL,
             valign=Gtk.Align.CENTER, vexpand=True, spacing=12,
         )
-        no_bat_icon = Gtk.Image(icon_name="battery-missing-symbolic", pixel_size=64,
-                                 opacity=0.5)
+        no_bat_icon = Gtk.Image(
+            icon_name="battery-missing-symbolic", pixel_size=64,
+            opacity=0.5)
         no_bat_label = Gtk.Label(label="No battery detected")
         no_bat_label.add_css_class("title-2")
         no_bat_label.set_opacity(0.5)

gui/archer/pages/dashboard.py

@@ -8,7 +8,7 @@
 
 gi.require_version("Gtk", "4.0")
 gi.require_version("Adw", "1")
-from gi.repository import Gtk, Adw, GLib
+from gi.repository import Gtk, Adw
 
 # ---------------------------------------------------------------------------
 # Constants

gui/archer/pages/internals.py

@@ -5,7 +5,7 @@
 import gi
 gi.require_version("Gtk", "4.0")
 gi.require_version("Adw", "1")
-from gi.repository import Gtk, Adw, GLib
+from gi.repository import Gtk, Adw
 
 import threading
 
@@ -56,8 +56,9 @@ def _build_ui(self):
         onetime_buttons.append(btn_all)
 
         onetime_row = Adw.PreferencesRow()
-        onetime_inner = Gtk.Box(orientation=Gtk.Orientation.VERTICAL,
-                                 margin_start=12, margin_end=12, margin_bottom=12)
+        onetime_inner = Gtk.Box(
+            orientation=Gtk.Orientation.VERTICAL,
+            margin_start=12, margin_end=12, margin_bottom=12)
         onetime_inner.append(onetime_buttons)
         onetime_row.set_child(onetime_inner)
         onetime_group.add(onetime_row)
@@ -81,13 +82,15 @@ def _build_ui(self):
         self.override_combo.set_selected(0)
         permanent_group.add(self.override_combo)
 
-        apply_override_btn = Gtk.Button(label="Apply Override", halign=Gtk.Align.CENTER,
-                                         margin_top=8, margin_bottom=8)
+        apply_override_btn = Gtk.Button(
+            label="Apply Override", halign=Gtk.Align.CENTER,
+            margin_top=8, margin_bottom=8)
         apply_override_btn.add_css_class("suggested-action")
         apply_override_btn.connect("clicked", self._on_apply_override)
         override_row = Adw.PreferencesRow()
-        override_inner = Gtk.Box(margin_start=12, margin_end=12, margin_bottom=12,
-                                  halign=Gtk.Align.CENTER)
+        override_inner = Gtk.Box(
+            margin_start=12, margin_end=12, margin_bottom=12,
+            halign=Gtk.Align.CENTER)
         override_inner.append(apply_override_btn)
         override_row.set_child(override_inner)
         permanent_group.add(override_row)

gui/archer/pages/keyboard.py

@@ -10,7 +10,7 @@
 
 gi.require_version("Gtk", "4.0")
 gi.require_version("Adw", "1")
-from gi.repository import Gtk, Adw, Gdk, GLib
+from gi.repository import Gtk, Adw, Gdk
 
 
 # ── helpers ──────────────────────────────────────────────────────────

gui/archer/pages/system.py

@@ -5,7 +5,7 @@
 import gi
 gi.require_version("Gtk", "4.0")
 gi.require_version("Adw", "1")
-from gi.repository import Gtk, Adw, GLib
+from gi.repository import Gtk, Adw
 
 import threading
 import subprocess

gui/archer/window.py

@@ -154,7 +154,6 @@ def _on_settings_loaded(self, data):
             self.status_label.add_css_class("status-connected")
 
             # Push settings to all pages
-            features = data.get("features", [])
             self.dashboard_page.load_settings(data)
             self.performance_page.load_settings(data)
             self.battery_page.load_settings(data)