Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ossia - max] latest release regenerates node tree when new model is added #832

Open
maybites opened this issue Oct 25, 2023 · 1 comment

Comments

@maybites
Copy link
Contributor

maybites commented Oct 25, 2023

consider the follwing patcher:


----------begin_max5_patcher----------
940.3oc0X1rbaBCDG+L9ofQmcxf3KC8TeK5gLYxfAUGkfQdDxNNMSd2K5CvH
ABrcRyjdHfyh.s6uc+KzxaKb.qIGQ0.2e3dmqiyaKbbDl3FbT+uCXa1w7xrZ
wv.UnWHqeBrTdIF5HSXdGEWwZstKik+HtZyCTTNS9vSiu0aoa7J9w.e9Q+li
t2qtip8awUkHlXNfmLR1yZs5orhKDSXiSbyJ.2z6KVvOr7iE.j5Zb1sEnC3b
ja8tLZ9yyFN9hvABCFDO4jRBUNTuag9QgoKa9wpzXuUI7ekjFBgM+BdYL.Nj
AIsdobXrW2gjyK.3d+GFOGxnUYaEOQvKD5yMfIGML469KyqYkYPn3Th2z0.d
maMfu1LhnpPSEaNfeiKQGPzZLopGAc.Y610yrSuagCjmjYuzkclvURSdclnM
0Js2ePm0lBmGwrlfdOUhsiwgfSOFRAhVsGKbEowlTixkDIANtkjjey7bU6kO
Qx33HgNJNkeJLPbBFkdBlNfMTbQM9OphAXjbH8Gglzue72uDQytQoBirYSIp
K3FOqC8j46DQ9Nr8XmaXqxW87nM3fgnOfpxVWhzR.1TGhqTeXivG66c8pZB6
aefxguTlT73zJfTYpqjTZhJSsCZ6N1qmGECEqbFAM0NV0OyPodDANIQ.Zyjg
TSOxsJ4rI6Lt8wjeVjf1kgyKEsIG0jjmgrzPZFI0hPwo3Pwpbg7E65CvyPcN
tB0DUl0eCttQcnLupwfwq2BhDUZAdxWX60dTy+lR5Zew6wJ9RLcobx1snJlo
DVdeUEniFYrdpTck5GkXCViyFw7SEDKIx95byCrYVuaZ0rs08FtqIiqMy5e+
Co6f0EGaOYTzVBC4doYBXZpkcmcMEuA14Yzr7DrT82WBTOePEB6Apu00rg+m
Uy1AEUYq6O4tp6ZBo7BpfCTExQeFUv91oq+4UA+8Au72aWNXiS127jFN8R+L
vIzNNgyiyIQo9l.JwUysI.QLyG2zbtlrml25Bp2D3NDBEnZFtJio1S0cc0H7
wdUU.Wq+EcA9WxnikPKj6S06aqiGNsiC+Rc7vKvwilshPuPlPwavUJcRiCdC
LBrXrsbCpyNfJdnYNZjvOjwXT758LoHXr9M1TRVmUpZJo6yUz+YORqbm5Cdf
.6T2cigwd83M.ePS7McNeR2Z.tRkQTKoliRse.jonibhUegHwTqSC4GLxjBp
OazfnWSBZIxWcJx0lVi9B4SgQefF8+MruO686Y1mm.g15qaw6K9KihbBI.
-----------end_max5_patcher-----------

on the console you will find the following output:

print: node created sparck:/empty
print: node created sparck:/empty/toggle
print: parameter created sparck:/empty/toggle
  1. open subpatcher "workspace"
  2. copy paste subpatcher "empty"

the folloing output appears:

print: parameter removed sparck:/empty/toggle
print: node removed sparck:/empty/toggle
print: node removed sparck:/empty
print: node created sparck:/empty
print: node created sparck:/empty/toggle
print: parameter created sparck:/empty/toggle
print: node created sparck:/empty.1
print: node created sparck:/empty.1/toggle
print: parameter created sparck:/empty.1/toggle

The printout of step 2 indicates that the node tree has been rebuilt. In my opinion this is undesired behaviour. It shouldn't rebuild the whole node tree, but only add the new nodes sparck:/empty.1 and sparck:/empty.1/toggle.

case in point:

  1. repeat it again:
print: node created sparck:/empty.2
print: node created sparck:/empty.2/toggle
print: parameter created sparck:/empty.2/toggle

doing it a second time doesn't rebuild the node tree.

This behaviour is undesired because once you load a patcher and load parameters into the node tree and then add another node, you loose all the parameters loaded and you have to reload them again.

@maybites
Copy link
Contributor Author

maybites commented Jan 4, 2025

I updated the above bug report to make the issue clearer to reproduce and understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant