Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ComplexRoundabout more granular error messaging #709

Open
vladlemberg opened this issue Dec 2, 2020 · 1 comment
Open

ComplexRoundabout more granular error messaging #709

vladlemberg opened this issue Dec 2, 2020 · 1 comment

Comments

@vladlemberg
Copy link
Contributor

Description
ComplexRoundabout validation combining multiple errors into single ComplexEntityError. This approach makes more difficult adding an AutoFix suggestion to MalformedRoundaboutCheck.

Proposal
Break ComplexEntityError into individual Errors:
Before
WRONG_WAY_INVALIDATION = "This roundabout is going the wrong direction, or has been improperly tagged as a roundabout.";
After
WRONG_WAY_INVALIDATION = "This roundabout is going the wrong direction";
WRONG_WAY_TAGGING = "This way has been improperly tagged as a roundabout.";

Example 1
Wrong Way
Autofix suggestion - reverse geometry

Example 2
Wrong tagging
Autofix suggestion - remove junction=roundabout tag.

Currently both cases falls with the same error message and can't be differentiated for Autofix implementation.

@Bentleysb
Copy link
Contributor

@vladlemberg, the second example only fails with the WRONG_WAY_INVALIDATION? It looks like it should also have an INCOMPLETE_ROUTE_INVALIDATION, as it does not form a closed route.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants