You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Description
ComplexRoundabout validation combining multiple errors into single ComplexEntityError. This approach makes more difficult adding an AutoFix suggestion to MalformedRoundaboutCheck.
Proposal
Break ComplexEntityError into individual Errors:
Before WRONG_WAY_INVALIDATION = "This roundabout is going the wrong direction, or has been improperly tagged as a roundabout.";
After WRONG_WAY_INVALIDATION = "This roundabout is going the wrong direction"; WRONG_WAY_TAGGING = "This way has been improperly tagged as a roundabout.";
Example 1 Wrong Way
Autofix suggestion - reverse geometry
Example 2 Wrong tagging
Autofix suggestion - remove junction=roundabout tag.
Currently both cases falls with the same error message and can't be differentiated for Autofix implementation.
The text was updated successfully, but these errors were encountered:
@vladlemberg, the second example only fails with the WRONG_WAY_INVALIDATION? It looks like it should also have an INCOMPLETE_ROUTE_INVALIDATION, as it does not form a closed route.
Description
ComplexRoundabout validation combining multiple errors into single ComplexEntityError. This approach makes more difficult adding an AutoFix suggestion to MalformedRoundaboutCheck.
Proposal
Break ComplexEntityError into individual Errors:
Before
WRONG_WAY_INVALIDATION = "This roundabout is going the wrong direction, or has been improperly tagged as a roundabout.";
After
WRONG_WAY_INVALIDATION = "This roundabout is going the wrong direction";
WRONG_WAY_TAGGING = "This way has been improperly tagged as a roundabout.";
Example 1
Wrong Way
Autofix suggestion - reverse geometry
Example 2
Wrong tagging
Autofix suggestion - remove junction=roundabout tag.
Currently both cases falls with the same error message and can't be differentiated for Autofix implementation.
The text was updated successfully, but these errors were encountered: