Skip to content

Commit e380796

Browse files
authored
fix tensorflow build and mention v1.13.0 in the doc (LeelaChessZero#774)
1 parent 9d37464 commit e380796

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/neural/network_tf.cc

+1
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,7 @@ class TFNetworkComputation : public NetworkComputation {
205205
float GetQVal(int sample) const override {
206206
return output_[0].template matrix<float>()(sample, 0);
207207
}
208+
float GetDVal(int sample) const override { return 0.0f; }
208209
float GetPVal(int sample, int move_id) const override {
209210
return output_[1].template matrix<float>()(sample, move_id);
210211
}

tensorflow.md

+7-6
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,12 @@
11
To build with tensorflow under linux you need to install Tensorflow_cc from
2-
<https://github.com/FloopCZ/tensorflow_cc>. Either release v1.9.0 or v1.12.0.
3-
Tensorflow_cc requires a specific version of protobuf, which constrains the
4-
build. Release v1.9.0 works out of the box, since the default protobuf
2+
<https://github.com/FloopCZ/tensorflow_cc>. Either release v1.9.0, v1.12.0 or
3+
v1.13.0. Tensorflow_cc requires a specific version of protobuf, which constrains
4+
the build. Release v1.9.0 works out of the box, since the default protobuf
55
subproject (v3.5.1) is compatible and is used instead of a system installed
6-
version. In contrast release v1.12.0 needs protobuf v3.6.0 which can be built
7-
by adding `-Dprotobuf-3-6-0=true` to the build command line. Note that this
8-
protobuf version has issues with static builds and crashes so is not
6+
version. In contrast release v1.12.0 needs protobuf v3.6.0 and release v1.13.0
7+
is built with protobuf 3.6.1 but also works with 3.6.0. For those versions
8+
`-Dprotobuf-3-6-0=true` should be added to the build command line. Note that
9+
this protobuf version has issues with static builds and crashes so is not
910
recommended for normal use. The crashes look very similar to:
1011
* <https://github.com/protocolbuffers/protobuf/issues/5107>
1112
* <https://github.com/protocolbuffers/protobuf/issues/5353>

0 commit comments

Comments
 (0)