Verify network bandwidth analysis misses connection budget overruns 🤖

[lwrage]

Summary

The Verify NetworkBandWidthAnalysis plug-in still invokes the deprecated bus-load implementation instead of NewBusLoadAnalysis.

The deprecated implementation treats actual bandwidth > connection budget only as a CSV note and uses the actual value in the aggregate bus calculation. When the aggregate remains below bus capacity, it creates no error marker. Verify can therefore accept a network-bandwidth claim that the current bus-load analysis rejects.

Reproduction

Create a connection with an 8 KB/s bandwidth budget and 16 KB/s calculated actual load, bound to a bus with 96 KB/s capacity.

Run the bus-load analysis from the OSATE analysis command: the connection receives an error diagnostic. Invoke Verify NetworkBandWidthAnalysis: the deprecated analyzer records only Actual bandwidth exceeds bandwidth budget. Using actual, and the bus remains below capacity, so no error marker is produced.

Expected behavior

Verify network bandwidth analysis should invoke the current bus-load implementation and produce the same connection budget-overrun diagnostics as the OSATE bus-load command.

Relevant code

alisa/org.osate.verify/src/org/osate/verify/analysisplugins/AnalysisPluginInterface.xtend, method NetworkBandWidthAnalysis.

analyses/org.osate.analysis.resource.budgets/src/org/osate/analysis/resource/budgets/logic/BusLoadAnalysis.java, method checkBandWidthLoad.

[lwrage]

Closing because the review scope excludes the ALISA/Verify integration path.