chore: fix linter

Author: wewelll

driver/configuration/provider_koanf_public_test.go

@@ -13,7 +13,7 @@ import (
 	"github.com/rs/cors"
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"go.opentelemetry.io/otel/trace"
+	"go.opentelemetry.io/otel/trace/noop"
 
 	"github.com/ory/x/configx"
 	"github.com/ory/x/logrusx"
@@ -248,7 +248,7 @@ func TestKoanfProvider(t *testing.T) {
 		})
 
 		t.Run("authenticator=cookie_session", func(t *testing.T) {
-			a := authn.NewAuthenticatorCookieSession(p, logger, trace.NewNoopTracerProvider())
+			a := authn.NewAuthenticatorCookieSession(p, logger, noop.NewTracerProvider())
 			assert.True(t, p.AuthenticatorIsEnabled(a.GetID()))
 			require.NoError(t, a.Validate(nil))
 
@@ -286,7 +286,7 @@ func TestKoanfProvider(t *testing.T) {
 		})
 
 		t.Run("authenticator=oauth2_introspection", func(t *testing.T) {
-			a := authn.NewAuthenticatorOAuth2Introspection(p, logger, trace.NewNoopTracerProvider())
+			a := authn.NewAuthenticatorOAuth2Introspection(p, logger, noop.NewTracerProvider())
 			assert.True(t, p.AuthenticatorIsEnabled(a.GetID()))
 			require.NoError(t, a.Validate(nil))
 
@@ -434,7 +434,7 @@ func TestAuthenticatorOAuth2TokenIntrospectionPreAuthorization(t *testing.T) {
 		{enabled: true, id: "a", secret: "b", turl: "https://some-url", err: false},
 	} {
 		t.Run(fmt.Sprintf("case=%d", k), func(t *testing.T) {
-			a := authn.NewAuthenticatorOAuth2Introspection(p, logrusx.New("", ""), trace.NewNoopTracerProvider())
+			a := authn.NewAuthenticatorOAuth2Introspection(p, logrusx.New("", ""), noop.NewTracerProvider())
 
 			config, _, err := a.Config(json.RawMessage(fmt.Sprintf(`{
 	"pre_authorization": {

pipeline/authn/authenticator_cookie_session.go

@@ -4,7 +4,7 @@
 package authn
 
 import (
-	"crypto/md5"
+	"crypto/md5" //#nosec G501 -- MD5 is used for cache key generation, not cryptography
 	"encoding/json"
 	"fmt"
 	"io"
@@ -189,7 +189,7 @@ func cookiesToCacheKey(cookies []*http.Cookie) string {
 	for _, cookie := range cookies {
 		parts = append(parts, fmt.Sprintf("%s=%s", cookie.Name, cookie.Value))
 	}
-	return fmt.Sprintf("%x", md5.Sum([]byte(strings.Join(parts, "|"))))
+	return fmt.Sprintf("%x", md5.Sum([]byte(strings.Join(parts, "|")))) //#nosec G401 -- MD5 is used for cache key generation, not cryptography
 }
 
 type cachedSessionData struct {

pipeline/authn/authenticator_cookie_session_cache_test.go

@@ -11,7 +11,7 @@ import (
 
 	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
-	"go.opentelemetry.io/otel/trace"
+	"go.opentelemetry.io/otel/trace/noop"
 
 	"github.com/ory/oathkeeper/driver/configuration"
 	"github.com/ory/x/configx"
@@ -31,7 +31,7 @@ func TestCookieSessionCache(t *testing.T) {
 		}))
 	require.NoError(t, err)
 
-	a := NewAuthenticatorCookieSession(c, logger, trace.NewNoopTracerProvider())
+	a := NewAuthenticatorCookieSession(c, logger, noop.NewTracerProvider())
 	assert.Equal(t, "cookie_session", a.GetID())
 
 	config, err := a.Config(nil)
@@ -50,7 +50,6 @@ func TestCookieSessionCache(t *testing.T) {
 			a.sessionToCache(config, req, subject, extra)
 			time.Sleep(time.Millisecond * 10)
 
-			subject = "modified-subject"
 			v := a.sessionFromCache(config, req)
 			require.NotNil(t, v)
 			require.Equal(t, "test-subject", v.Subject)