feat: migrate SQLite driver from mattn/go-sqlite3 to modernc.org/sqlite and remove CGO dep

GitOrigin-RevId: 4b06aa7218156efb69b9edf0ff6c4a8e5e8de046

Author: aeneasr

.docker/Dockerfile-local-build

@@ -12,12 +12,10 @@ RUN apt-get update && apt-get upgrade -y &&\
 COPY go.mod go.sum ./
 COPY internal/httpclient/go.* ./internal/httpclient/
 
-ENV CGO_ENABLED=1
-
 RUN go mod download
 
 COPY . .
-RUN go build -ldflags="-extldflags=-static" -tags sqlite,sqlite_omit_load_extension -o /usr/bin/hydra
+RUN go build -ldflags="-extldflags=-static" -o /usr/bin/hydra
 
 #########################
 

.docker/Dockerfile-test-hsm

@@ -17,7 +17,7 @@ ENV CGO_ENABLED=1
 RUN go mod download
 COPY . .
 
-RUN go build -tags sqlite,hsm -o /usr/bin/hydra
+RUN go build -tags hsm -o /usr/bin/hydra
 
 ENV HSM_ENABLED=true
 ENV HSM_LIBRARY=/usr/lib/softhsm/libsofthsm2.so
@@ -33,4 +33,4 @@ RUN go test -p 1 -failfast -short -tags=sqlite,hsm ./...
 
 FROM builder AS test-refresh-hsm
 
-RUN UPDATE_SNAPSHOTS=true go test -p 1 -failfast -short -tags=sqlite,hsm,refresh ./...
+RUN UPDATE_SNAPSHOTS=true go test -p 1 -failfast -short -tags=hsm,refresh ./...

.github/workflows/ci.yaml

@@ -84,7 +84,7 @@ jobs:
           only-new-issues: "true"
       - name: Run go tests
         run: |
-          go test -coverprofile coverage.out -failfast -timeout=20m -tags sqlite,sqlite_omit_load_extension ./...
+          go test -coverprofile coverage.out -failfast -timeout=20m ./...
       - name: Submit to Codecov
         run: |
           bash <(curl -s https://codecov.io/bash)

CONTRIBUTING.md

@@ -165,8 +165,8 @@ request, go through this checklist:
 1. Create a feature branch off of `master` so that changes do not get mixed up.
 1. [Rebase](http://git-scm.com/book/en/Git-Branching-Rebasing) your local
    changes against the `master` branch.
-1. Run the full project test suite with the `go test -tags sqlite ./...` (or
-   equivalent) command and confirm that it passes.
+1. Run the full project test suite with the `go test ./...` (or equivalent)
+   command and confirm that it passes.
 1. Run `make format`
 1. Add a descriptive prefix to commits. This ensures a uniform commit history
    and helps structure the changelog. Please refer to this

DEVELOP.md

@@ -58,24 +58,24 @@ There are three types of tests:
 Short tests run fairly quickly and use SQLite in-memory.
 
 All tests run against a sqlite in-memory database, thus it is required to use
-the `-tags sqlite` build tag.
+the `` build tag.
 
 Run all short tests:
 
 ```shell
-go test -v -failfast -short -tags sqlite ./...
+go test -v -failfast -short  ./...
 ```
 
 Run short tests in a specific module:
 
 ```shell
-go test -v -failfast -short -tags sqlite ./client
+go test -v -failfast -short  ./client
 ```
 
 Run a specific test:
 
 ```shell
-go test -v -failfast -short -tags sqlite -run ^TestName$ ./...
+go test -v -failfast -short  -run ^TestName$ ./...
 ```
 
 ### Regular tests

Makefile

@@ -36,7 +36,7 @@ lint: .bin/golangci-lint
 .PHONY: test
 test:
 	make test-resetdb
-	source scripts/test-env.sh && go test -failfast -timeout=20m -tags sqlite,sqlite_omit_load_extension ./...
+	source scripts/test-env.sh && go test -failfast -timeout=20m ./...
 	docker rm -f hydra_test_database_mysql
 	docker rm -f hydra_test_database_postgres
 	docker rm -f hydra_test_database_cockroach
@@ -68,15 +68,15 @@ e2e: node_modules test-resetdb
 # Runs tests in short mode, without database adapters
 .PHONY: quicktest
 quicktest:
-	go test -failfast -short -tags sqlite,sqlite_omit_load_extension ./...
+	go test -failfast -short ./...
 
 .PHONY: quicktest-hsm
 quicktest-hsm:
 	DOCKER_CONTENT_TRUST=1 docker build --progress=plain -f .docker/Dockerfile-test-hsm --target test-hsm -t oryd/hydra:${IMAGE_TAG} --target test-hsm .
 
 .PHONY: test-refresh
 test-refresh:
-	UPDATE_SNAPSHOTS=true go test -short -tags sqlite,sqlite_omit_load_extension ./...
+	UPDATE_SNAPSHOTS=true go test -short ./...
 	DOCKER_CONTENT_TRUST=1 docker build --progress=plain -f .docker/Dockerfile-test-hsm --target test-refresh-hsm -t oryd/hydra:${IMAGE_TAG} --target test-refresh-hsm .
 
 authors:  # updates the AUTHORS file
@@ -169,14 +169,13 @@ install-stable:
 	HYDRA_LATEST=$$(git describe --abbrev=0 --tags)
 	git checkout $$HYDRA_LATEST
 	go install \
-		-tags sqlite,sqlite_omit_load_extension \
 		-ldflags "-X github.com/ory/hydra/v2/driver/config.Version=$$HYDRA_LATEST -X github.com/ory/hydra/v2/driver/config.Date=`TZ=UTC date -u '+%Y-%m-%dT%H:%M:%SZ'` -X github.com/ory/hydra/v2/driver/config.Commit=`git rev-parse HEAD`" \
 		.
 	git checkout master
 
 .PHONY: install
 install:
-	go install -tags sqlite,sqlite_omit_load_extension .
+	go install .
 
 .PHONY: pre-release
 pre-release:

cmd/server/helper_cert_test.go

@@ -18,13 +18,13 @@ import (
 	"github.com/stretchr/testify/require"
 
 	"github.com/ory/x/configx"
+	"github.com/ory/x/dbal"
 	"github.com/ory/x/logrusx"
 	"github.com/ory/x/servicelocatorx"
 	"github.com/ory/x/tlsx"
 
 	"github.com/ory/hydra/v2/cmd/server"
 	"github.com/ory/hydra/v2/driver"
-	"github.com/ory/hydra/v2/driver/config"
 	"github.com/ory/hydra/v2/internal/testhelpers"
 	"github.com/ory/hydra/v2/jwk"
 )
@@ -35,11 +35,12 @@ func TestGetOrCreateTLSCertificate(t *testing.T) {
 	logger.Logger.ExitFunc = func(code int) { t.Fatalf("Logger called os.Exit(%v)", code) }
 	d, err := driver.New(t.Context(),
 		driver.WithConfigOptions(configx.WithValues(map[string]interface{}{
-			"dsn":                 config.DSNMemory,
+			"dsn":                 dbal.NewSQLiteTestDatabase(t),
 			"serve.tls.enabled":   true,
 			"serve.tls.cert.path": certPath,
 			"serve.tls.key.path":  keyPath,
 		})),
+		driver.WithAutoMigrate(),
 		driver.WithServiceLocatorOptions(servicelocatorx.WithLogger(logger)),
 	)
 	require.NoError(t, err)
@@ -107,12 +108,15 @@ func TestGetOrCreateTLSCertificateBase64(t *testing.T) {
 	require.NoError(t, err)
 	keyBase64 := base64.StdEncoding.EncodeToString(keyPEM)
 
-	d, err := driver.New(t.Context(), driver.WithConfigOptions(configx.WithValues(map[string]interface{}{
-		"dsn":                   config.DSNMemory,
-		"serve.tls.enabled":     true,
-		"serve.tls.cert.base64": certBase64,
-		"serve.tls.key.base64":  keyBase64,
-	})))
+	d, err := driver.New(t.Context(),
+		driver.WithConfigOptions(configx.WithValues(map[string]interface{}{
+			"dsn":                   dbal.NewSQLiteTestDatabase(t),
+			"serve.tls.enabled":     true,
+			"serve.tls.cert.base64": certBase64,
+			"serve.tls.key.base64":  keyBase64,
+		})),
+		driver.WithAutoMigrate(),
+	)
 	require.NoError(t, err)
 	getCert := server.GetOrCreateTLSCertificate(t.Context(), d, d.Config().ServeAdmin(t.Context()).TLS, "admin")
 	require.NotNil(t, getCert)

driver/config/provider.go

@@ -11,22 +11,22 @@ import (
 	"net/http"
 	"net/url"
 	"strings"
+	"sync"
 	"testing"
 	"time"
 
 	"github.com/stretchr/testify/require"
 
-	"github.com/gofrs/uuid"
 	"github.com/pkg/errors"
 
 	"github.com/ory/hydra/v2/spec"
 	"github.com/ory/hydra/v2/x"
 	"github.com/ory/x/configx"
 	"github.com/ory/x/contextx"
-	"github.com/ory/x/dbal"
 	"github.com/ory/x/hasherx"
 	"github.com/ory/x/logrusx"
 	"github.com/ory/x/otelx"
+
 	"github.com/ory/x/randx"
 	"github.com/ory/x/stringslice"
 	"github.com/ory/x/urlx"
@@ -130,9 +130,11 @@ var (
 )
 
 type DefaultProvider struct {
-	l *logrusx.Logger
-	p *configx.Provider
-	c contextx.Contextualizer
+	l                 *logrusx.Logger
+	p                 *configx.Provider
+	c                 contextx.Contextualizer
+	dsnOnce           sync.Once
+	sqliteInMemoryDSN string
 }
 
 func (p *DefaultProvider) GetHasherAlgorithm(ctx context.Context) string {
@@ -299,7 +301,15 @@ func (p *DefaultProvider) DSN() string {
 	dsn := p.getProvider(contextx.RootContext).String(KeyDSN)
 
 	if dsn == DSNMemory {
-		return dbal.NewSQLiteInMemoryDatabase(uuid.Must(uuid.NewV4()).String())
+		p.dsnOnce.Do(func() {
+			fn, err := randx.RuneSequence(12, randx.AlphaNum)
+			if err != nil {
+				p.l.Fatal("could not create temp dir for SQLite database")
+			}
+
+			p.sqliteInMemoryDSN = fmt.Sprintf("sqlite://file:%s?_fk=true&mode=memory&cache=shared&_busy_timeout=100000&_time_format=sqlite", string(fn))
+		})
+		return p.sqliteInMemoryDSN
 	}
 
 	if len(dsn) > 0 {
@@ -513,6 +523,7 @@ func (p *DefaultProvider) KratosAdminURL(ctx context.Context) (*url.URL, bool) {
 
 	return u, u != nil
 }
+
 func (p *DefaultProvider) KratosPublicURL(ctx context.Context) (*url.URL, bool) {
 	u := p.getProvider(ctx).RequestURIF(KeyIdentityProviderPublicURL, nil)
 

driver/registry_sql_test.go

@@ -39,9 +39,9 @@ func init() {
 func TestGetJWKSFetcherStrategyHostEnforcement(t *testing.T) {
 	t.Parallel()
 
-	r, err := New(t.Context(), WithConfigOptions(
+	r, err := New(t.Context(), WithAutoMigrate(), WithConfigOptions(
 		configx.WithValues(map[string]any{
-			config.KeyDSN:                         "memory",
+			config.KeyDSN:                         dbal.NewSQLiteTestDatabase(t),
 			config.HSMEnabled:                     "false",
 			config.KeyClientHTTPNoPrivateIPRanges: true,
 		}),
@@ -146,7 +146,7 @@ func TestDefaultKeyManager_HsmDisabled(t *testing.T) {
 		WithConfigOptions(
 			configx.SkipValidation(),
 			configx.WithValues(map[string]any{
-				config.KeyDSN:     "memory",
+				config.KeyDSN:     dbal.NewSQLiteTestDatabase(t),
 				config.HSMEnabled: false,
 			}),
 		),

fosite/CONTRIBUTING.md

@@ -151,8 +151,8 @@ request, go through this checklist:
 1. Create a feature branch off of `master` so that changes do not get mixed up.
 1. [Rebase](http://git-scm.com/book/en/Git-Branching-Rebasing) your local
    changes against the `master` branch.
-1. Run the full project test suite with the `go test -tags sqlite ./...` (or
-   equivalent) command and confirm that it passes.
+1. Run the full project test suite with the `go test ./...` (or equivalent)
+   command and confirm that it passes.
 1. Run `make format`
 1. Add a descriptive prefix to commits. This ensures a uniform commit history
    and helps structure the changelog. Please refer to this