Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ignore marker at the beginning of the url #93

Open
3 of 6 tasks
jooola opened this issue Sep 10, 2022 · 0 comments
Open
3 of 6 tasks

Move ignore marker at the beginning of the url #93

jooola opened this issue Sep 10, 2022 · 0 comments
Labels
bug Something is not working.

Comments

@jooola
Copy link

jooola commented Sep 10, 2022

Preflight checklist

Describe the bug

Related to 5d419e0

[Code] editors usually make link clickable for developers convenience. The ignore marker at the end of the URL might get consider as part of the URL and clicking on them will open a HTTP 404 in our browsers.

Some link checkers might also get confused by this, and report false positives.

Moving the ignore marker a the beginning of the URL should prevent mixing them together as we often have the scheme that delimits the beginning of the URL.

I see that the regex rule to extract the links does not contain any scheme, but maybe we could use https://regex101.com/r/K8XC3H/1 ?

(!!)?((https?:)?\/\/)?github\.com\/([a-zA-Z\d-]+)\/([a-zA-Z\d._-]+)\/(pull|issues)\/(\d+)(!!)?

Reproducing the bug

  • Open your IDE and click on a link with the ignore markers.
  • Should open a 404 in your browser

Relevant log output

No response

Relevant configuration

No response

Version

v1

On which operating system are you observing this issue?

No response

In which environment are you deploying?

No response

Additional Context

No response

@jooola jooola added the bug Something is not working. label Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working.
Projects
None yet
Development

No branches or pull requests

1 participant