Vega Strike
Do we need to continue supporting the legacy data dir mode? #1001
-
Originally posted by @royfalk in #999 (comment) |
Beta Was this translation helpful? Give feedback.
Replies: 3 comments 5 replies
-
|
My vote is no. Whatever reason the original dev team had to support the old way of doing things, it's been about 20 years, since they made the switch. Anyone who's still using the legacy dir mode, they can darn well switch over to the new way. |
Beta Was this translation helpful? Give feedback.
-
|
I added it. It was part of our refactors/changes. |
Beta Was this translation helpful? Give feedback.
-
|
So I added the legacy dir mode to help with migrations. I figured we would eventually drop the support of the legacy mode and drop the old binary names too. I forget what version we introduced it with, but we should be able to give a warning about removing it in either 0.9.x or 0.10.x and then drop it in the next release after that. Sound fair? |
Beta Was this translation helpful? Give feedback.
-
|
Yes. |
Beta Was this translation helpful? Give feedback.
-
|
Cool. Why don't we warn about removing it in 0.10.x, and then we can remove it in 0.11.x or whatever the next version is after 0.10? |
Beta Was this translation helpful? Give feedback.
-
|
0.11.x should be after 0.10.x right now. We're still a far way from hitting the 1.0 mark. |
Beta Was this translation helpful? Give feedback.
-
|
Yeah, you're probably right. |
Beta Was this translation helpful? Give feedback.
-
|
Looks like we formed a consensus around @BenjamenMeyer 's answer. Let's go with that. |
Beta Was this translation helpful? Give feedback.
So I added the legacy dir mode to help with migrations.
if the binary is called
vegastrike(the legacy name) then it used the old legacy behavior about trying to automatically load the assets.if the binary is called
vegastrike-engine(the new name) then it uses the new behavior of requiring the assets be passed as a parameter.I figured we would eventually drop the support of the legacy mode and drop the old binary names too. I forget what version we introduced it with, but we should be able to give a warning about removing it in either 0.9.x or 0.10.x and then drop it in the next release after that. Sound fair?