[FEDEX] API not returning transit_days or esimated_delivery #739

[danh91]

@vangelow

Describe the bug
Whatever API request I try I never get transit_days and/or estimated_delivery when using Fedex API integration and not Fedex WS (with this one I always get transit days)

To Reproduce
Steps to reproduce the behavior:

1. Make a POST request to /v1/proxy/rates while having a Fedex API (not WS) carrier setup
2. Check for transit_days or estimated_delivery

Expected behavior
Any information about an estimated delivery or transit days is part of the response.

Screenshots
API response example below

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Additional context
Here you can see that there is not information at all about transit_days - This is one item from the "rates" key of the response

    {
      "id": "rat_de158d436c324b358a8fae1e414c8967",
      "object_type": "rate",
      "carrier_name": "fedex",
      "carrier_id": "fedex",
      "currency": "SEK",
      "service": "fedex_international_priority",
      "total_charge": 141.95,
      "extra_charges": [
        {
          "name": "Base Charge",
          "amount": 1005.16,
          "currency": "SEK"
        },
        {
          "name": "Discounts",
          "amount": 0,
          "currency": "SEK"
        },
        {
          "name": "Fuel Surcharge",
          "amount": 27.64,
          "currency": "SEK"
        },
        {
          "name": "Demand Surcharge",
          "amount": 10.97,
          "currency": "SEK"
        },
        {
          "name": "Other",
          "amount": 17.43,
          "currency": "SEK"
        }
      ],
      "meta": {
        "service_name": "FEDEX INTERNATIONAL PRIORITY",
        "ext": "fedex",
        "carrier": "fedex",
        "rate_provider": "fedex",
        "carrier_connection_id": "car_b4eb51669e4c4fadaa9cdf43f3efc577"
      },
      "test_mode": false
    },

@danh91 Please if there is some idea to trigger the transit days to be returned, because I read something about that being part of the request also give us a sign.

[vangelow]

@danh91 Found the solution on this problem as well after discussions with Fedex. They metnioned that the delivery date is not returned ,because we are sending the commodities descriptions as "N/A". After sending the description with a curl, set to "Personal documents" for example i get the delivery date

                    "deliveryDate": "2025-02-12T20:00:00",
                    "deliveryDay": "WED",
                    "commitDate": "2025-02-12T20:00:00",
                    "commitDays": [
                        "WED"
                    ],

Does not return dates

                "commodities": [
                    {
                        "customsValue": {"amount": 1, "currency": "USD"},
                        "description": "Personal documents",
                        "numberOfPieces": 1,
                        "partNumber": "0000",
                        "quantity": 1,
                        "quantityUnits": "PCS",
                        "unitPrice": {"amount": 1, "currency": "USD"},
                        "weight": {"units": "KG", "value": 1},
                    }
                ],

                "commodities": [
                    {
                        "customsValue": {"amount": 1, "currency": "USD"},
                        "description": "N/A",
                        "numberOfPieces": 1,
                        "partNumber": "0000",
                        "quantity": 1,
                        "quantityUnits": "PCS",
                        "unitPrice": {"amount": 1, "currency": "USD"},
                        "weight": {"units": "KG", "value": 1},
                    }
                ],

[danh91]

Hi @vangelow ,

I can replace the "N/A" as default, but ultimately, you have control over the commodity description, you need to provide it to the Karrio API parcels.items[].title or description

karrio/modules/connectors/fedex/karrio/providers/fedex/rate.py

Line 292 in 8401bfe

description=lib.text(

[vangelow]

@danh91 Sorry, Dan. I totally forgot to mention that this is on the proxy/rates api call. I do not have the possibility to set the description of a commodity item there. That fix should be applied only to proxy/rates or if you can provide us with the possibility to add commodity details there it would also work

[vangelow]

@danh91 Sorry, somehow i did not saw that i can also pass commodities on fetch/rates. Is it a fairly new feature or it has always been like this ? I might have missed that somehow :/ Anyway, fixed it on my side, thanks

[danh91]

It is old; they were both added around the same time. While each package can have a variety of commodities in them, the customs commodities (required for international shipments) are a combined list of unique commodities from all the packages with their total quantities.