From fe610f61ed3961c4a7af47231fba87c1a3b69487 Mon Sep 17 00:00:00 2001 From: raph Date: Fri, 17 Jan 2025 17:07:07 +0100 Subject: [PATCH] Update minimum Bitcoin version to v28 (#4185) --- crates/mockcore/src/lib.rs | 2 +- docs/src/guides/wallet.md | 2 +- src/wallet.rs | 2 +- tests/wallet/inscribe.rs | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/crates/mockcore/src/lib.rs b/crates/mockcore/src/lib.rs index 13304f8f99..c2cc76b5fa 100644 --- a/crates/mockcore/src/lib.rs +++ b/crates/mockcore/src/lib.rs @@ -96,7 +96,7 @@ pub fn builder() -> Builder { Builder { fail_lock_unspent: false, network: Network::Bitcoin, - version: 250000, + version: 280000, } } diff --git a/docs/src/guides/wallet.md b/docs/src/guides/wallet.md index 8160d30525..74056206b7 100644 --- a/docs/src/guides/wallet.md +++ b/docs/src/guides/wallet.md @@ -43,7 +43,7 @@ Installing Bitcoin Core Bitcoin Core is available from [bitcoincore.org](https://bitcoincore.org/) on the [download page](https://bitcoincore.org/en/download/). -Making inscriptions requires Bitcoin Core 25 or newer. +Making inscriptions requires Bitcoin Core 28 or newer. This guide does not cover installing Bitcoin Core in detail. Once Bitcoin Core is installed, you should be able to run `bitcoind -version` successfully from diff --git a/src/wallet.rs b/src/wallet.rs index 35db651d62..e138f7bf66 100644 --- a/src/wallet.rs +++ b/src/wallet.rs @@ -606,7 +606,7 @@ impl Wallet { } pub(crate) fn check_version(client: Client) -> Result { - const MIN_VERSION: usize = 250000; + const MIN_VERSION: usize = 280000; let bitcoin_version = client.version()?; if bitcoin_version < MIN_VERSION { diff --git a/tests/wallet/inscribe.rs b/tests/wallet/inscribe.rs index 0b328f8af7..993d706e04 100644 --- a/tests/wallet/inscribe.rs +++ b/tests/wallet/inscribe.rs @@ -80,7 +80,7 @@ fn inscribe_fails_if_bitcoin_core_is_too_old() { CommandBuilder::new("wallet inscribe --file hello.txt --fee-rate 1") .write("hello.txt", "HELLOWORLD") .expected_exit_code(1) - .expected_stderr("error: Bitcoin Core 25.0.0 or newer required, current version is 24.0.0\n") + .expected_stderr("error: Bitcoin Core 28.0.0 or newer required, current version is 24.0.0\n") .core(&core) .ord(&ord) .run_and_extract_stdout();