removed useless stuff

Author: orange-cpp

.gitmodules

@@ -1,6 +1,3 @@
 [submodule "extlibs/googletest"]
 	path = extlibs/googletest
-	url = https://github.com/google/googletest.git
-[submodule "extlibs/glm"]
-	path = extlibs/glm
-	url = https://github.com/g-truc/glm.git
+	url = https://github.com/google/googletest.git

extlibs/glm

@@ -4,7 +4,6 @@
 #pragma once
 #include "Constants.h"
 
-
 namespace omath::source
 {
     [[nodiscard]]

include/omath/engines/OpenGL/Constants.hpp

@@ -13,7 +13,7 @@ namespace omath::prediction
     public:
 
         [[nodiscard]]
-        constexpr Vector3 PredictPosition(float time, float gravity) const
+        constexpr Vector3 PredictPosition(const float time, const float gravity) const
         {
             auto predicted = m_origin + m_velocity * time;
 

include/omath/engines/OpenGL/Formulas.hpp

@@ -58,7 +58,7 @@ namespace omath::prediction
                 return std::nullopt;
 
         root = std::sqrt(root);
-        const float angle = std::atan((std::pow(projectile.m_launchSpeed, 2.f) - root) / (bulletGravity * distance2d));
+        const float angle = std::atan((launchSpeedSqr - root) / (bulletGravity * distance2d));
 
         return angles::RadiansToDegrees(angle);
     }

include/omath/engines/OpenGL/OpenGL.hpp

@@ -10,9 +10,12 @@ namespace omath::prediction
 {
     Vector3 Projectile::PredictPosition(const float pitch, const float yaw, const float time, const float gravity) const
     {
-        auto currentPos = m_origin + omath::source::ForwardVector({source::PitchAngle::FromDegrees(-pitch), source::YawAngle::FromDegrees(yaw), source::RollAngle::FromDegrees(0)}) * m_launchSpeed * time;
-        currentPos.z -= (gravity * m_gravityScale) * std::pow(time, 2.f) * 0.5f;
+        auto currentPos = m_origin + source::ForwardVector({source::PitchAngle::FromDegrees(-pitch),
+                                                            source::YawAngle::FromDegrees(yaw),
+                                                            source::RollAngle::FromDegrees(0)}) *
+                                             m_launchSpeed * time;
+        currentPos.z -= (gravity * m_gravityScale) * (time * time) * 0.5f;
 
         return currentPos;
     }
-}
+} // namespace omath::prediction

include/omath/engines/Source/Formulas.hpp

@@ -9,7 +9,7 @@
 
 TEST(UnitTestSourceEngine, ForwardVector)
 {
-    const auto forward = omath::source::ForwardVector({{}, {}, {}});
+    const auto forward = omath::source::ForwardVector({});
 
     EXPECT_EQ(forward, omath::source::kAbsForward);
 }

include/omath/engines/Unity/Unity.hpp

@@ -3,8 +3,9 @@
 
 TEST(UnitTestPrediction, PredictionTest)
 {
-    const omath::prediction::Target target{.m_origin = {100, 0, 90}, .m_velocity = {0, 0, 0}, .m_isAirborne = false};
-    const omath::prediction::Projectile proj = {.m_origin = {3,2,1}, .m_launchSpeed = 5000, .m_gravityScale= 0.4};
+    constexpr omath::prediction::Target target{
+            .m_origin = {100, 0, 90}, .m_velocity = {0, 0, 0}, .m_isAirborne = false};
+    constexpr omath::prediction::Projectile proj = {.m_origin = {3,2,1}, .m_launchSpeed = 5000, .m_gravityScale= 0.4};
     const auto viewPoint = omath::prediction::Engine(400, 1.f / 1000.f, 50, 5.f).MaybeCalculateAimPoint(proj, target);
 
     const auto [pitch, yaw, _] = proj.m_origin.ViewAngleTo(viewPoint.value()).AsTuple();