Expression evaluation

[wieczorek1990]

https://github.com/oracle/truffleruby/blob/master/lib/truffle/weakref.rb#L50

Should we use something like:

expression_a = a(...)
expression_b(expression_a)

Rather than what is there now:

expression_b(a(...))

[eregon]

Why?

[wieczorek1990]

I basically think of it as naming the expression results for readablity. W dniu pon., 18.03.2024 o 16:12 Benoit Daloze ***@***.***> napisał(a):

…

Why? — Reply to this email directly, view it on GitHub <#3496 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMRLK2GMQSD2V7ZUQTGPLTYY376XAVCNFSM6AAAAABE3Y276SVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4DQMRZGQ2TM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[eregon]

I don't think it would help readability here.
It's certainly not something to apply in general, it depends a lot on the context whether an extra local variable helps readability.

[wieczorek1990]

I think it helps complexity destructuring too. W dniu pon., 18.03.2024 o 17:45 Benoit Daloze ***@***.***> napisał(a):

…

I don't think it would help readability here. It's certainly not something to apply in general, it depends a lot on the context whether an extra local variable helps readability. — Reply to this email directly, view it on GitHub <#3496 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMRLK4W7O7IW45NMPMWJADYY4KZBAVCNFSM6AAAAABE3Y276SVHI2DSMVQWIX3LMV43SRDJONRXK43TNFXW4Q3PNVWWK3TUHM4DQMZQGYZDM> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[wieczorek1990]

I am amending the example for correctness:

expression_a_result = expression_a(a_expression_parameters...)
expression_b_result = expression_b(expression_a_result)
expression_b_result

versus:

expression_b(expression_a(a_expression_parameters...))

I know the argument against are interpreters, compilers without chaining of expressions.