Allow getScale to return 0 for NUMBER

Author: Michael-A-McMahon

src/main/java/oracle/r2dbc/impl/OracleReadableMetadataImpl.java

@@ -296,6 +296,12 @@ static ColumnMetadata createColumnMetadata(
     Nullability nullability = getNullability(fromJdbc(() ->
       resultSetMetaData.isNullable(jdbcIndex)));
 
+    if (type == R2dbcType.NUMERIC) {
+      // For NUMBER, allow the scale to be 0
+      return new OracleColumnMetadataImpl(type, name, nullability,
+        fromJdbc(() -> resultSetMetaData.getPrecision(jdbcIndex)),
+        fromJdbc(() -> resultSetMetaData.getScale(jdbcIndex)));
+    }
     if (type == R2dbcType.BLOB
       || type == R2dbcType.CLOB
       || type == R2dbcType.NCLOB

src/test/java/oracle/r2dbc/impl/OracleReadableMetadataImplTest.java

@@ -158,6 +158,11 @@ public void testNumericTypes() {
         connection, "NUMBER(5,3)", JDBCType.NUMERIC, R2dbcType.NUMERIC, 5, 3,
         BigDecimal.class, BigDecimal.valueOf(12.345));
 
+      // Expect getScale() to return 0 for NUMBER .
+      verifyColumnMetadata(
+        connection, "NUMBER(5,0)", JDBCType.NUMERIC, R2dbcType.NUMERIC, 5, 0,
+        BigDecimal.class, BigDecimal.valueOf(12345));
+
       // Expect FLOAT and Double to map.
       verifyColumnMetadata(
         connection, "FLOAT(6)", JDBCType.FLOAT, R2dbcType.FLOAT, 6, null,