Added support for ISO 8601 date strings with "Z" appended.

For example: "2019-07-13T16:48:05Z"

Author: connelly38

nosqldb/data_ops_test.go

@@ -1296,7 +1296,10 @@ func (suite *DataOpsTestSuite) TestTimestampDataType() {
 		tsValue       interface{} // Note: specify a string or time.Time value
 		shouldSucceed bool
 	}{
+		{"2019-07-13T16:48:05.123456789Z", true},
+		{"2019-07-13T16:48:05Z", true},
 		{"2019-07-13T16:48:05.123456789", true},
+		{"2019-07-13T16:48:05", true},
 		// Use Unix Epoch time
 		{epoch, true},
 		// 1970-01-01T00:00:00.999999999
@@ -1433,6 +1436,9 @@ func (suite *DataOpsTestSuite) runTimestampTest(table string, ts interface{}, pu
 	case string:
 		strVal := ts.(string)
 		tsTimeVal, err = time.Parse(types.ISO8601Layout, strVal)
+		if err != nil {
+			tsTimeVal, err = time.Parse(types.ISO8601ZLayout, strVal)
+		}
 		suite.Require().NoErrorf(err, "failed to parse %q into time.Time, got error: %v", strVal, err)
 
 	case time.Time:
@@ -1517,7 +1523,7 @@ func (suite *DataOpsTestSuite) runTimestampTest(table string, ts interface{}, pu
 				expect = tsTimeVal.Round(time.Nanosecond * d)
 			}
 
-			suite.Truef(expect.Equal(actual), "unexpect timestamp value returned, expect %v, got %v.", expect, actual)
+			suite.Truef(expect.Equal(actual), "unexpected timestamp value returned, expect %v, got %v.", expect, actual)
 		}
 	}
 

nosqldb/internal/proto/binary/reader.go

@@ -298,7 +298,11 @@ func (r *Reader) ReadFieldValue() (types.FieldValue, error) {
 		if s == nil {
 			return nil, errors.New("binary.Reader: invalid Timestamp value")
 		}
-		return time.Parse(types.ISO8601Layout, *s)
+		v, err := time.Parse(types.ISO8601Layout, *s)
+		if err == nil {
+			return v, nil
+		}
+		return time.Parse(types.ISO8601ZLayout, *s)
 
 	case types.Number:
 		s, err := r.ReadString()

nosqldb/types/types.go

@@ -199,8 +199,15 @@ func (ttl TimeToLive) ToDuration() time.Duration {
 	return time.Duration(numOfHours) * time.Hour
 }
 
+// NOTE: the date values in these are not random! They reference specific
+// fields based on their numerical strings. For example, "2006" is the
+// definition for stdLongYear. These do not follow C-style formatting.
+// See the consts in https://golang.org/src/time/format.go for more detail.
+
 // ISO8601Layout represents the ISO 8601 format of Go's reference time.
 const ISO8601Layout = "2006-01-02T15:04:05.999999999"
+// ISO8601ZLayout includes literal "Z"
+const ISO8601ZLayout = "2006-01-02T15:04:05.999999999Z"
 
 // FieldRange defines a range of values to be used in a Client.MultiDelete()
 // operation, as specified in MultiDeleteRequest.FieldRange.