Skip to content

Commit 675e3cd

Browse files
refactor: rename customLogger to useCustomLogger
- Update 'Constants.swift' to change 'customLogger' to 'useCustomLogger' - Update 'SwiftOptimizelyFlutterSdkPlugin.swift' to change 'customLogger' to 'useCustomLogger' - Update 'optimizely_flutter_sdk.dart' to change 'logger' parameter to 'OptimizelyLogger' - Update 'optimizely_client_wrapper.dart' to change 'customLogger' to 'useCustomLogger' - Update 'constants.dart' to change 'customLogger' to 'useCustomLogger'
1 parent 387adc5 commit 675e3cd

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

ios/Classes/HelperClasses/Constants.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ struct RequestParameterKey {
9191
static let reasons = "reasons"
9292
static let decideOptions = "optimizelyDecideOption"
9393
static let defaultLogLevel = "defaultLogLevel"
94-
static let customLogger = "customLogger"
94+
static let useCustomLogger = "useCustomLogger"
9595
static let eventBatchSize = "eventBatchSize"
9696
static let eventTimeInterval = "eventTimeInterval"
9797
static let eventMaxQueueSize = "eventMaxQueueSize"

ios/Classes/SwiftOptimizelyFlutterSdkPlugin.swift

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,8 @@ public class SwiftOptimizelyFlutterSdkPlugin: NSObject, FlutterPlugin {
3636
return UUID().uuidString
3737
}
3838

39-
static var registrar: FlutterPluginRegistrar?
4039
/// Registers optimizely_flutter_sdk channel to communicate with the flutter sdk to receive requests and send responses
4140
public static func register(with registrar: FlutterPluginRegistrar) {
42-
self.registrar = registrar
4341
channel = FlutterMethodChannel(name: "optimizely_flutter_sdk", binaryMessenger: registrar.messenger())
4442
let instance = SwiftOptimizelyFlutterSdkPlugin()
4543
registrar.addMethodCallDelegate(instance, channel: channel)
@@ -176,7 +174,10 @@ public class SwiftOptimizelyFlutterSdkPlugin: NSObject, FlutterPlugin {
176174

177175
// Check if custom logger is requested
178176
var logger: OPTLogger?
179-
if let useCustomLogger = parameters[RequestParameterKey.customLogger] as? Bool, useCustomLogger {
177+
if let useCustomLogger = parameters[RequestParameterKey.useCustomLogger] as? Bool, useCustomLogger {
178+
// OptimizelyFlutterLogger bridges iOS logs to Flutter via Method Channel
179+
// When useCustomLogger = true:
180+
// iOS SDK log → OptimizelyFlutterLogger → Flutter Method Channel → Flutter console
180181
logger = OptimizelyFlutterLogger()
181182
}
182183

lib/optimizely_flutter_sdk.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ class OptimizelyFlutterSdk {
8989
Set<OptimizelyDecideOption> defaultDecideOptions = const {},
9090
OptimizelyLogLevel defaultLogLevel = OptimizelyLogLevel.info,
9191
SDKSettings sdkSettings = const SDKSettings(),
92-
OptimizelyLogger? logger}) // Add logger parameter
92+
OptimizelyLogger? logger})
9393
: _eventOptions = eventOptions,
9494
_datafilePeriodicDownloadInterval = datafilePeriodicDownloadInterval,
9595
_datafileHostOptions = datafileHostOptions,

lib/src/optimizely_client_wrapper.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ class OptimizelyClientWrapper {
8080
Constants.eventBatchSize: eventOptions.batchSize,
8181
Constants.eventTimeInterval: eventOptions.timeInterval,
8282
Constants.eventMaxQueueSize: eventOptions.maxQueueSize,
83-
Constants.customLogger: logger != null,
83+
Constants.useCustomLogger: logger != null,
8484
};
8585

8686
// Odp Request params

lib/src/utils/constants.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ class Constants {
8686
static const String optimizelyDecideOption = "optimizelyDecideOption";
8787
static const String optimizelySegmentOption = "optimizelySegmentOption";
8888
static const String optimizelySdkSettings = "optimizelySdkSettings";
89-
static const String customLogger = 'customLogger';
89+
static const String useCustomLogger = 'useCustomLogger';
9090
static const String defaultLogLevel = "defaultLogLevel";
9191
static const String payload = "payload";
9292
static const String value = "value";

0 commit comments

Comments
 (0)