chore: Prepare for 4.2.1 release (#550)

Author: mjc1283

packages/optimizely-sdk/CHANGELOG.MD

@@ -7,6 +7,11 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [4.2.1] - August 10, 2020
+
+### Bug fixes
+  - Remove incorrect warning about invalid variation ID when user not bucketed into experiment or feature rollout ([#549](https://github.com/optimizely/javascript-sdk/pull/549))
+
 ## [4.2.0] - July 31, 2020
 
 ### New Features

packages/optimizely-sdk/lib/core/bucketer/index.js

@@ -114,8 +114,10 @@ export var bucket = function(bucketerParams) {
   var entityId = this._findBucket(bucketValue, bucketerParams.trafficAllocationConfig);
 
   if (!bucketerParams.variationIdMap.hasOwnProperty(entityId)) {
-    var invalidVariationIdLogMessage = sprintf(LOG_MESSAGES.INVALID_VARIATION_ID, MODULE_NAME);
-    bucketerParams.logger.log(LOG_LEVEL.WARNING, invalidVariationIdLogMessage);
+    if (entityId) {
+      var invalidVariationIdLogMessage = sprintf(LOG_MESSAGES.INVALID_VARIATION_ID, MODULE_NAME);
+      bucketerParams.logger.log(LOG_LEVEL.WARNING, invalidVariationIdLogMessage);
+    }
     return null;
   }
 
@@ -128,7 +130,7 @@ export var bucket = function(bucketerParams) {
  * @param {string} bucketingId  Bucketing ID
  * @param {string} userId       ID of user to be bucketed into experiment
  * @param {Object} logger       Logger implementation
- * @return {string} ID of experiment if user is bucketed into experiment within the group, null otherwise
+ * @return {string|null} ID of experiment if user is bucketed into experiment within the group, null otherwise
  */
 export var bucketUserIntoExperiment = function(group, bucketingId, userId, logger) {
   var bucketingKey = sprintf('%s%s', bucketingId, group.id);
@@ -148,7 +150,7 @@ export var bucketUserIntoExperiment = function(group, bucketingId, userId, logge
  * @param  {Object[]} trafficAllocationConfig
  * @param  {number}   trafficAllocationConfig[].endOfRange
  * @param  {number}   trafficAllocationConfig[].entityId
- * @return {string}   Entity ID for bucketing if bucket value is within traffic allocation boundaries, null otherwise
+ * @return {string|null}   Entity ID for bucketing if bucket value is within traffic allocation boundaries, null otherwise
  */
 export var _findBucket = function(bucketValue, trafficAllocationConfig) {
   for (var i = 0; i < trafficAllocationConfig.length; i++) {

packages/optimizely-sdk/lib/core/bucketer/index.tests.js

@@ -286,6 +286,15 @@ describe('lib/core/bucketer', function() {
           bucketerParamsTest1.userId = 'ppid1';
           expect(bucketer.bucket(bucketerParamsTest1)).to.equal(null);
         });
+
+        it('should not log an invalid variation ID warning', function() {
+          bucketer.bucket(bucketerParams)
+          const foundInvalidVariationWarning = createdLogger.log.getCalls().some((call) => {
+            const message = call.args[1];
+            return message.includes('Bucketed into an invalid variation ID')
+          });
+          expect(foundInvalidVariationWarning).to.equal(false);
+        });
       });
 
       describe('when the traffic allocation has invalid variation ids', function() {

packages/optimizely-sdk/lib/index.browser.tests.js

@@ -148,7 +148,7 @@ describe('javascript-sdk', function() {
         optlyInstance.onReady().catch(function() {});
 
         assert.instanceOf(optlyInstance, Optimizely);
-        assert.equal(optlyInstance.clientVersion, '4.2.0');
+        assert.equal(optlyInstance.clientVersion, '4.2.1');
       });
 
       it('should set the JavaScript client engine and version', function() {

packages/optimizely-sdk/lib/index.node.tests.js

@@ -90,7 +90,7 @@ describe('optimizelyFactory', function() {
         optlyInstance.onReady().catch(function() {});
 
         assert.instanceOf(optlyInstance, Optimizely);
-        assert.equal(optlyInstance.clientVersion, '4.2.0');
+        assert.equal(optlyInstance.clientVersion, '4.2.1');
       });
 
       describe('event processor configuration', function() {

packages/optimizely-sdk/lib/index.react_native.tests.js

@@ -89,7 +89,7 @@ describe('javascript-sdk/react-native', function() {
         optlyInstance.onReady().catch(function() {});
 
         assert.instanceOf(optlyInstance, Optimizely);
-        assert.equal(optlyInstance.clientVersion, '4.2.0');
+        assert.equal(optlyInstance.clientVersion, '4.2.1');
       });
 
       it('should set the Javascript client engine and version', function() {

packages/optimizely-sdk/lib/utils/enums/index.js

@@ -172,7 +172,7 @@ export var CONTROL_ATTRIBUTES = {
 export var JAVASCRIPT_CLIENT_ENGINE = 'javascript-sdk';
 export var NODE_CLIENT_ENGINE = 'node-sdk';
 export var REACT_CLIENT_ENGINE = 'react-sdk';
-export var NODE_CLIENT_VERSION = '4.2.0';
+export var NODE_CLIENT_VERSION = '4.2.1';
 
 export var VALID_CLIENT_ENGINES = [
   NODE_CLIENT_ENGINE,

packages/optimizely-sdk/package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "@optimizely/optimizely-sdk",
-  "version": "4.2.0",
+  "version": "4.2.1",
   "description": "JavaScript SDK for Optimizely X Full Stack",
   "module": "dist/optimizely.browser.es.min.js",
   "main": "dist/optimizely.node.min.js",