Skip to content

Commit 55329d1

Browse files
authored
Removed client engine validation
## Summary Removed Client engine validation in the SDK to allow tracking events from new clients without friction. ## Test plan - Manually Tested - All tests pass
1 parent 94794ee commit 55329d1

File tree

4 files changed

+1
-38
lines changed

4 files changed

+1
-38
lines changed

packages/optimizely-sdk/lib/optimizely/index.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export default class Optimizely {
8585

8686
constructor(config: OptimizelyOptions) {
8787
let clientEngine = config.clientEngine;
88-
if (enums.VALID_CLIENT_ENGINES.indexOf(clientEngine) === -1) {
88+
if (!clientEngine) {
8989
config.logger.log(
9090
LOG_LEVEL.INFO,
9191
LOG_MESSAGES.INVALID_CLIENT_ENGINE,

packages/optimizely-sdk/lib/optimizely_user_context/index.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ import {
2828
} from '../../lib/shared_types';
2929
import { DECISION_MESSAGES, LOG_MESSAGES } from '../utils/enums';
3030

31-
const MODULE_NAME = 'OPTIMIZELY_USER_CONTEXT';
32-
3331
const logger = getLogger();
3432

3533
export default class OptimizelyUserContext {

packages/optimizely-sdk/lib/utils/enums/index.tests.js

Lines changed: 0 additions & 27 deletions
This file was deleted.

packages/optimizely-sdk/lib/utils/enums/index.ts

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -183,14 +183,6 @@ export const REACT_NATIVE_CLIENT_ENGINE = 'react-native-sdk';
183183
export const REACT_NATIVE_JS_CLIENT_ENGINE = 'react-native-js-sdk';
184184
export const NODE_CLIENT_VERSION = '4.8.0-beta';
185185

186-
export const VALID_CLIENT_ENGINES = [
187-
NODE_CLIENT_ENGINE,
188-
REACT_CLIENT_ENGINE,
189-
JAVASCRIPT_CLIENT_ENGINE,
190-
REACT_NATIVE_CLIENT_ENGINE,
191-
REACT_NATIVE_JS_CLIENT_ENGINE,
192-
];
193-
194186
export const NOTIFICATION_TYPES = notificationTypesEnum;
195187

196188
export const DECISION_NOTIFICATION_TYPES = {

0 commit comments

Comments
 (0)