Release version 1.3.1 (#110)

Author: elliotykim

CHANGELOG.md

@@ -1,4 +1,9 @@
 # Optimizely Android X SDK Changelog
+### 1.3.1
+April 25, 2017
+
+- Handle exceptions in top-level APIs
+
 ### 1.3.0
 April 12, 2017
 

android-sdk/src/main/java/com/optimizely/ab/android/sdk/DataFileClient.java

@@ -84,7 +84,7 @@ public String execute() {
                         logger.error("Unexpected response from data file cdn, status: {}", status);
                         return null;
                     }
-                } catch (IOException e) {
+                } catch (Exception e) {
                     logger.error("Error making request", e);
                     return null;
                 } finally {

android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyClient.java

@@ -120,7 +120,11 @@ public boolean isValid() {
     public void track(@NonNull String eventName,
                       @NonNull String userId) {
         if (isValid()) {
-            optimizely.track(eventName, userId);
+            try {
+                optimizely.track(eventName, userId);
+            } catch (Exception e) {
+                logger.error("Unable to track event", e);
+            }
         } else {
             logger.warn("Optimizely is not initialized, could not track event {} for user {}", eventName, userId);
         }
@@ -139,8 +143,8 @@ public void track(@NonNull String eventName,
             optimizely.track(eventName, userId, attributes);
 
         } else {
-            logger.warn("Optimizely is not initialized, could not track event {} for user {}" +
-                    " with attributes", eventName, userId);
+            logger.warn("Optimizely is not initialized, could not track event {} for user {} with attributes",
+                    eventName, userId);
         }
     }
 

android-sdk/src/main/java/com/optimizely/ab/android/sdk/OptimizelyManager.java

@@ -41,10 +41,10 @@
 import com.optimizely.ab.android.shared.Client;
 import com.optimizely.ab.android.shared.OptlyStorage;
 import com.optimizely.ab.android.shared.ServiceScheduler;
+import com.optimizely.ab.android.user_profile.AndroidUserProfile;
 import com.optimizely.ab.bucketing.UserProfile;
 import com.optimizely.ab.config.parser.ConfigParseException;
 import com.optimizely.ab.event.internal.payload.Event;
-import com.optimizely.ab.android.user_profile.AndroidUserProfile;
 
 import org.json.JSONObject;
 import org.slf4j.Logger;
@@ -153,9 +153,10 @@ public OptimizelyClient initialize(@NonNull Context context, @NonNull String dat
             optimizelyClient = buildOptimizely(context, datafile, userProfile);
         } catch (ConfigParseException e) {
             logger.error("Unable to parse compiled data file", e);
+        } catch (Exception e) {
+            logger.error("Unable to build OptimizelyClient instance", e);
         }
 
-
         // After instantiating the OptimizelyClient, we will begin the datafile sync so that next time
         // the user can instantiate with the latest datafile
         final Intent intent = new Intent(context.getApplicationContext(), DataFileService.class);
@@ -369,12 +370,16 @@ protected void onPostExecute(UserProfile userProfile) {
                     } else {
                         logger.info("No listener to send Optimizely to");
                     }
-                } catch (ConfigParseException e) {
+                } catch (Exception e) {
                     logger.error("Unable to build optimizely instance", e);
                 }
             }
         };
-        initUserProfileTask.executeOnExecutor(executor);
+        try {
+            initUserProfileTask.executeOnExecutor(executor);
+        } catch (Exception e) {
+            logger.error("Unable to initialize the user profile while injecting Optimizely", e);
+        }
     }
 
     private OptimizelyClient buildOptimizely(@NonNull Context context, @NonNull String dataFile, @NonNull UserProfile userProfile) throws ConfigParseException {
@@ -617,7 +622,13 @@ public Builder withDataFileDownloadInterval(long interval, @NonNull TimeUnit tim
          * @return a {@link Builder} instance
          */
         public OptimizelyManager build() {
-            final Logger logger = LoggerFactory.getLogger(OptimizelyManager.class);
+            Logger logger;
+            try {
+                logger = LoggerFactory.getLogger(OptimizelyManager.class);
+            } catch (Exception e) {
+                logger = LoggerFactory.getLogger("Optly.androidSdk");
+                logger.error("Unable to generate logger from class");
+            }
 
             // AlarmManager doesn't allow intervals less than 60 seconds
             if (dataFileDownloadIntervalTimeUnit.toMillis(dataFileDownloadInterval) < (60 * 1000)) {
@@ -634,7 +645,6 @@ public OptimizelyManager build() {
                     dataFileDownloadIntervalTimeUnit,
                     Executors.newSingleThreadExecutor(),
                     logger);
-
         }
     }
 }