-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Wiki changes can't push currently #5699
Comments
After #5700 was merged, it seems like the wiki deployment did not re-run: It's not obvious to me at all why it didn't run for the latest develop changes--I'd actually expect it to run every PR that gets merged but it doesn't seem like that's the case. Edit: Ah, nevermind this does make sense. The triggers filter based on changes to the wiki folder, and that PR didn't. I'll manually re-run the deploy script for the wiki and verify that it updated. |
Looks like we're going to need support for |
## Explanation Fixes part of #5699 (even though it's already expected to be fixed). This was missed in #5700. We can't verify the fixes from that PR without the ability to re-run the workflow outside of a PR (or until another PR that modifies the wiki is merged). It seems ideal to have the ability to force-refresh the wiki in this way, anyway. Similar to #5700, this can't be easily verified until it's merged. ## Essential Checklist - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only N/A -- This only affects GitHub actions wiki workflows.
Describe the bug
Attempts to update the wiki are failing during wiki deployment:
From https://github.com/oppia/oppia-android/actions/runs/13187896020/job/36818438965#step:3:264.
Steps To Reproduce
Make a change to the wiki and submit the PR, or manually trigger a wiki deployment via the actions workflow.
Expected Behavior
Deployment should succeed.
Screenshots/Videos
No response
What device/emulator are you using?
N/A
Which Android version is your device/emulator running?
N/A
Which version of the Oppia Android app are you using?
N/A
Additional Context
This is very likely tied to a policy update made at the Oppia organization level recently where
GITHUB_TOKEN
was restricted to only have "read repository contents and packages" permissions. Oppia web and Android have different approaches for deployment which is why we're only seeing this for Android:GITHUB_TOKEN
since the workflow isn't running cross-repository:oppia-android/.github/workflows/wiki.yml
Lines 38 to 53 in a4317ba
https://docs.github.com/en/actions/security-for-github-actions/security-guides/automatic-token-authentication#permissions-for-the-github_token describes the permission levels for
GITHUB_TOKEN
. I suspect all we need to do is update the required permissions for the workflow so that it has the correct permissions per https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/controlling-permissions-for-github_token#defining-access-for-the-github_token-permissions.The text was updated successfully, but these errors were encountered: