Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add content description for each image region in ImageRegionSelectionInteraction #3708

Closed
FareesHussain opened this issue Aug 19, 2021 · 1 comment · Fixed by #5691
Closed

Add content description for each image region in ImageRegionSelectionInteraction #3708

FareesHussain opened this issue Aug 19, 2021 · 1 comment · Fixed by #5691
Assignees
@manas-yu
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
1.x GA Follow-up ...

Comments

@FareesHussain
Copy link
Contributor

FareesHussain commented Aug 19, 2021 •
edited by rt4914
Loading

Description
ImageRegionSelectionInteraction does not contain contentDescription and therefore fails on accessibility scanner

Steps to reproduce

  1. Open First Test Topic
  2. Open Image Region Selection Exploration
  3. Using accessibility scanner take screenshot of the screen which shows all planets.
  4. Notice that the scanner fails with various errors

Expected solution
The scanner should should 0 errors.

For each image region we should add content description. Follow files can help you get started:

  • app/src/main/java/org/oppia/android/app/player/state/ImageRegionSelectionInteractionView.kt
  • app/src/main/res/layout/image_region_selection_interaction_item.xml
@FareesHussain FareesHussain changed the title Use content description for image regions in ImageRegionSelectionInteraction Add content description for each image region in ImageRegionSelectionInteraction Aug 19, 2021
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@BenHenning
Copy link
Member

I'm taking this to mean fixing the content descriptions in the test exploration that includes an image region selection instance.

@seanlip seanlip added enhancement End user-perceivable enhancements. bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure enhancement End user-perceivable enhancements. labels Mar 28, 2023
@rt4914 rt4914 added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. and removed Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. labels May 16, 2023
@adhiamboperes adhiamboperes added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label May 30, 2023
@BenHenning BenHenning removed the Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. label Jun 6, 2023
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
@manas-yu manas-yu self-assigned this Feb 3, 2025
@manas-yu manas-yu mentioned this issue Feb 4, 2025
Merged
6 tasks
adhiamboperes pushed a commit that referenced this issue Feb 18, 2025
@manas-yu
Fix #3708: Content Description Generation For ImageRegionSelectionInt…
d7eaad8 
…eraction (#5691)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fix #3708

This PR adds logic for dynamic content descriptions in
**ImageRegionSelectionInteraction**, i.e. generating distinct
descriptions for selected and not selected regions. For example:
- **Selected:** "Image showing Region 3." 
- **Not Selected:** "Select Region 3 image."

## Before

![image](https://github.com/user-attachments/assets/ddce71d7-f092-431a-af12-2d8e7ec727f3)

![image](https://github.com/user-attachments/assets/93764cf6-a1b8-4fa0-81b0-62b36a6f09d9)

## After

![image](https://github.com/user-attachments/assets/b23193f2-de50-4e30-a970-f45296f29483)

![image](https://github.com/user-attachments/assets/98e7f591-85df-4cb4-bb66-d38c1fb4e808)


## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@manas-yu manas-yu

Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Done
Milestone
1.x GA Follow-up Items
Development

Successfully merging a pull request may close this issue.

Fix #3708: Content Description Generation For ImageRegionSelectionInteraction manas-yu/oppia-android
7 participants
@rt4914 @seanlip @BenHenning @FareesHussain @adhiamboperes @Broppia @manas-yu