Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Previous responses header collapsed state not retained across landscape changes #1592

Open
rt4914 opened this issue Aug 10, 2020 · 4 comments · May be fixed by #5685
Open

Previous responses header collapsed state not retained across landscape changes #1592

rt4914 opened this issue Aug 10, 2020 · 4 comments · May be fixed by #5685
Assignees
@TanishMoral11
Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Aug 10, 2020 •
edited by adhiamboperes
Loading

Describe the bug
If the previous responses header is in expanded state in Exploration/Question player, on configuration change, it changes back to collapsed state.

To Reproduce
Steps to reproduce the behavior:

  1. Open any exploration / question player
  2. Mark 2-3 incorrect answers
  3. Click on Previous Responses so that it is now in expanded state
  4. Change configuration to landscape
  5. The Previous Responses header is now in collapsed state.

Expected behavior
Configuration change should persist the state of Previous Responses header.

Additional context: Please refer to PRs #5458 and #5478 for hints on how to resolve this.
@rt4914 rt4914 added Type: Bug Priority: Essential This work item must be completed for its milestone. labels Aug 10, 2020
@rt4914 rt4914 added this to the Beta milestone Aug 10, 2020
@rt4914 rt4914 mentioned this issue Aug 10, 2020
Closed
@prayutsu
Copy link
Contributor

I want to work on this issue.

@rt4914
Copy link
Contributor Author

rt4914 commented Aug 24, 2020

I have assigned you #1595 if that gets finished, then you can work on this too easily.

@rt4914 rt4914 changed the title Landscape support for Previous Responses Header Landscape support for Previous Responses Header [Blocked on #1737] Aug 28, 2020
@BenHenning BenHenning changed the title Landscape support for Previous Responses Header [Blocked on #1737] Previous responses header collapsed state not retained across landscape changes [Blocked on #1737] Aug 5, 2021
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta milestone Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_learner labels Mar 29, 2023
@rt4914 rt4914 changed the title Previous responses header collapsed state not retained across landscape changes [Blocked on #1737] Previous responses header collapsed state not retained across landscape changes [Blocked on #4470] Apr 12, 2023
@adhiamboperes adhiamboperes added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label May 30, 2023
@adhiamboperes adhiamboperes added Work: High It's not clear what the solution is. and removed Priority: Essential This work item must be completed for its milestone. labels Jul 9, 2023
@BenHenning BenHenning added this to the 1.0 Global availability milestone Aug 29, 2024
@adhiamboperes adhiamboperes changed the title Previous responses header collapsed state not retained across landscape changes [Blocked on #4470] Previous responses header collapsed state not retained across landscape changes Sep 11, 2024
@adhiamboperes adhiamboperes added Work: Low Solution is clear and broken into good-first-issue-sized chunks. good first issue This item is good for new contributors to make their pull request. and removed Work: High It's not clear what the solution is. Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Sep 17, 2024
@BenHenning BenHenning removed this from the 1.0 Global availability milestone Sep 25, 2024
@BenHenning
Copy link
Member

Note that since this isn't a major bug, we don't need to block the GA launch around this being fixed.

@TanishMoral11
Copy link
Collaborator

Hey @adhiamboperes , Can I work on it?

@TanishMoral11 TanishMoral11 self-assigned this Jan 1, 2025
@TanishMoral11 TanishMoral11 linked a pull request Feb 1, 2025 that will close this issue
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TanishMoral11 TanishMoral11

Labels
bug End user-perceivable behaviors which are not desirable. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Status: Todo
Milestone
No milestone
7 participants
@rt4914 @seanlip @BenHenning @prayutsu @adhiamboperes @Broppia @TanishMoral11