Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Proguard support to oppia_alpha_kitkat #3886

Closed
BenHenning opened this issue Oct 6, 2021 · 2 comments · Fixed by #5018
Closed

Add Proguard support to oppia_alpha_kitkat #3886

BenHenning opened this issue Oct 6, 2021 · 2 comments · Fixed by #5018
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

A forthcoming PR is introducing basic KitKat support in the app, and one limitation is that we must manually define the main dex class list in order for the main dex file to be set up correctly for multidex to kick-in. While Bazel supports both this & Proguard individually, it has a bug today in supporting these together (there's a sandbox issue when trying to call into dex_list_obfuscator.sh). I'm working on a change to patch the issue, but we'll need to wait for an Android tools update & Bazel re-deploy so it may be weeks before the build works.

From there, I suspect additional work might be needed since dex_list_obfuscator.sh appears to no-op actually updating the dex list, so we might need to manually add keep rules for each of the files in that list (we just need to run the Proguard-optimized version of the KitKat app on a KitKat device to test).
@BenHenning BenHenning mentioned this issue Oct 7, 2021
Merged
6 tasks
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 7, 2022
@BenHenning BenHenning added issue_user_developer Z-ibt Temporary label for Ben to keep track of issues he's triaged. and removed TODO: need task force labels Sep 16, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_type_infrastructure labels Mar 28, 2023
@seanlip
Copy link
Member

seanlip commented Jun 4, 2023

Per #5012, we are deprecating support for Android KitKat, so this issue is no longer valid.

@seanlip seanlip closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2023
@github-actions github-actions bot reopened this Jun 4, 2023
@github-actions
Copy link

github-actions bot commented Jun 4, 2023

The issue is reopened because of the following unresolved TODOs:

oppia-android/build_flavors.bzl

Line 95 in 81a95b7

"proguard_specs": [], # TODO(#3886): Re-add Proguard support to alpha_kitkat.

seanlip added a commit that referenced this issue Jun 5, 2023
@seanlip
Fix #3886 and #3887: drop remaining KitKat TODOs.
2d60ca5
@seanlip seanlip mentioned this issue Jun 5, 2023
Merged
6 tasks
adhiamboperes pushed a commit that referenced this issue Jun 5, 2023
@seanlip
Fix #3886 and #3887: drop remaining KitKat TODOs. (#5018)
f727c06 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
This PR fixes #3886 and fixes #3887 by dropping TODOs for those obsolete
issues so that they can be fully closed.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [ ] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #3886 and #3887: drop remaining KitKat TODOs. oppia/oppia-android
3 participants
@seanlip @BenHenning @Broppia